[regression/8.0.0-preview.5.8529] [MAUI] The 'New Recipe' page will crash in landscape mode on iOS simulator

[ZackYangyang]

Description

The 'New Recipe' page will crash in landscape mode.

Steps to Reproduce

1.Download the project https://github.com/rachelkang/recipeSearch and Locate it.
2.Tap on the 'My Recipes' tab to navigate to the 'My Recipes' page.
3.Tap on the 'New' button in the upper right-hand corner of the page to navigate to the 'New Recipe' page.
4.Rotate the emulator clockwise (to the right) to the landscape mode.

Actual result:
The 'New Recipe' page will crash in landscape mode
![image](https://github.com/dotnet/maui/assets/82210619/2b390281-8583-49bc-aeae-537c20f48ff3

Link to public reproduction project repository

https://github.com/rachelkang/recipeSearch

Version with bug

8.0.0-preview.5.8529

Is this a regression from previous behavior?

Yes, this used to work in .NET MAUI

Last version that worked well

8.0.0-preview.4.8333

Affected platforms

iOS

[rachelkang]

Tested and I'm able to reproduce this issue in preview7, so it is not a p7 to rc1 regression

[ZackYangyang]

We performed supplementary tests to verify the regression:
Repro this issue when use Microsoft.Maui.Controls 8.0.0-nightly.9158+sha.cad4279216-azdo.8352477 on .NET8 RC1/Preview7.
Repro this issue when use Microsoft.Maui.Controls 8.0.0-preview.7.8842 on .NET8 RC1/Preview7.

[drasticactions]

The complete stacktrace is

System.NullReferenceException: Object reference not set to an instance of an object.
    at Microsoft.Maui.Controls.Handlers.Items.ItemsViewController`1[[Microsoft.Maui.Controls.CarouselView, Microsoft.Maui.Controls, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null]].InvalidateMeasureIfContentSizeChanged()
    at Microsoft.Maui.Controls.Handlers.Items.ItemsViewController`1[[Microsoft.Maui.Controls.CarouselView, Microsoft.Maui.Controls, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null]].ViewWillLayoutSubviews()
    at Microsoft.Maui.Controls.Handlers.Items.CarouselViewController.ViewWillLayoutSubviews()
    at UIKit.UIApplication.UIApplicationMain(Int32 argc, String[] argv, IntPtr principalClassName, IntPtr delegateClassName)    at UIKit.UIApplication.Main(String[] args, Type principalClass, Type delegateClass)
    at Recipes.Program.Main(String[] args) in X:\Code\Work\recipeSearch\WhatToEat\Platforms\iOS\Program.cs:line 12} | System.NullReferenceException

And it seems specific to some devices and dimentions. It works on an iPhone 14, but not an iPhone 14 Pro Max.

And like @rachelkang, it happens in P7 too on the iPhone 14 Pro Max.

[XamlTest]

Verified this on Visual Studio Enterprise 17.8.0 Preview 1.0 using below Project (8.0.0-preview.7.8842), This issue repro on
iPhone 14 Pro Max and iPhone 14 Pro , not repro on iPhone 14.
recipeSearch.zip

Repro project:
iPhone 14 Pro Max

iPhone 14

[DDHSchmidt]

Guys, we can now reliably reproduce this crash with the exact same stacktrace on our app.
This worked fine on Preview 7 and is now crashing constantly on RC 1. Is there a hidden agenda in Microsoft to make the experience continuously worse on iOS?
I thought progressing versions should improve the stability, not reduce it?

Reliably crashing with an iPad Pro (10.5 inches) on iOS 16.6.1

[samhouts]

Confirmed that this regressed between 8.0.0-preview.4.8333 and 8.0.0-preview.5.8529. This new code path was added in #14951. This PR was backported to NET 7 (unreleased), so the fix has to go in NET 7, too.

[QianaJiao]

Verified this bug was fixed and not repro.
VSMac: 17.6.4 (17.6 build 472)
Microsoft.Maui.Controls: 8.0.0-nightly.9210+sha.39220c89b6-azdo.8394631
NET SDK: 8.0.100-rc.1.23455.8

[samhouts]

@QianaJiao I think you may have used a smaller simulator or device to test. This is still an issue on larger devices, like iPhone 14 Pro Max.

[PureWeen]

tracking additional work here