Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WinUI] Add tests for loading fonts when unpackaged #20791

Closed
PureWeen opened this issue Feb 22, 2024 · 2 comments
Closed

[WinUI] Add tests for loading fonts when unpackaged #20791

PureWeen opened this issue Feb 22, 2024 · 2 comments
Assignees
Labels
Milestone

Comments

@PureWeen
Copy link
Member

Description

Once we are ingesting a version of Win2D that can handle unpackaged fonts then we will add tests.

We did some exploratory work against the Win2D fix and found that we needed to add this code #20790 .

This will let people update manually to Win2D before we're actually depending on it ourselves.

@PureWeen PureWeen added this to the .NET 8 SR4 milestone Feb 22, 2024
@PureWeen PureWeen assigned mattleibow and Foda and unassigned mattleibow Feb 22, 2024
@mattleibow
Copy link
Member

we could potentially merge this for now and add tests in the https://github.com/dotnet/maui/blob/main/src/Controls/samples/Controls.Sample.UITests/Concepts/ImageLoadingGalleryPage.cs and https://github.com/dotnet/maui/blob/main/src/Controls/tests/UITests/Tests/Concepts/ImageLoadingGalleryTests.cs files. I currently just added the tests for the file-based images, not the generated ones.

@PureWeen PureWeen moved this from Todo to In Progress in MAUI SDK Ongoing Mar 15, 2024
@Foda
Copy link
Member

Foda commented Mar 26, 2024

Test added in #21212

@Foda Foda closed this as completed Mar 26, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in MAUI SDK Ongoing Mar 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Done
Development

No branches or pull requests

4 participants