Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Icons in Shell Tabs not showing in iOS #20866

Closed
ReamsIT-Darren opened this issue Feb 27, 2024 · 5 comments · Fixed by #22437
Closed

Font Icons in Shell Tabs not showing in iOS #20866

ReamsIT-Darren opened this issue Feb 27, 2024 · 5 comments · Fixed by #22437
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout area-fonts Custom fonts and Font related API's fixed-in-9.0.0-rc.2.24503.2 migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert platform/iOS 🍎 potential-regression This issue described a possible regression on a currently supported version., verification pending s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working

Comments

@ReamsIT-Darren
Copy link

Description

Font Icons are not showing in iOS builds in Shell Tabs but they are working in Android - this is the same issue as reported in #4774

Steps to Reproduce

Create MAUI app
Add relevant icon ttf file to app
Create shell, add icons to tabs via tabbar
Run on iOS local device

Link to public reproduction project repository

No response

Version with bug

8.0.3 GA

Is this a regression from previous behavior?

Yes, this used to work in Xamarin.Forms

Last version that worked well

6.0

Affected platforms

iOS

Affected platform versions

No response

Did you find any workaround?

Setting the FontImageSource Colour works but then it would need updating on selection to have selected and unselected different colours

Relevant log output

No response

@ReamsIT-Darren ReamsIT-Darren added the t/bug Something isn't working label Feb 27, 2024
@MitchBomcanhao
Copy link

I think this is a duplicate of #12250 and there's a workaround for this issue on #12250 (comment)

@jsuarezruiz jsuarezruiz added area-controls-shell Shell Navigation, Routes, Tabs, Flyout area-fonts Custom fonts and Font related API's labels Feb 27, 2024
@jfversluis jfversluis added platform/iOS 🍎 potential-regression This issue described a possible regression on a currently supported version., verification pending labels Feb 27, 2024
@ReamsIT-Darren
Copy link
Author

The workaround on #12250 does not seem to work when using Tabs on a Flyout on shell.

@samhouts samhouts added the migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert label Feb 27, 2024
@jaosnz-rep
Copy link

Verified this issue with Visual Studio 17.10.0 Preview 1. Can repro on .NET 8.0 iOS platform.

@jaosnz-rep jaosnz-rep added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Mar 6, 2024
@kubaflo
Copy link
Contributor

kubaflo commented Mar 14, 2024

This issue seems to be fixed - tested on iOS with 8.0.20-nightly.10316 and the following code:

<Shell.Resources>
		<ResourceDictionary>
			<Style x:Key="BaseStyle" TargetType="Element">
				<Setter Property="Shell.BackgroundColor" Value="{StaticResource PrimaryColor}" />
				<Setter Property="Shell.ForegroundColor" Value="Yellow" />
				<Setter Property="Shell.TitleColor" Value="Black" />
				<Setter Property="Shell.DisabledColor" Value="Pink" />
				<Setter Property="Shell.UnselectedColor" Value="Purple" />
				<Setter Property="Shell.TabBarBackgroundColor" Value="{StaticResource PrimaryColor}" />
				<Setter Property="Shell.TabBarForegroundColor" Value="Blue"/>
				<Setter Property="Shell.TabBarUnselectedColor" Value="Green"/>
				<Setter Property="Shell.TabBarTitleColor" Value="Red"/>
			</Style>
		</ResourceDictionary>
	</Shell.Resources>
	
	<TabBar>
		<ShellContent Title="About" ContentTemplate="{DataTemplate local:MainPage}">
			<ShellContent.Icon>
                <FontImageSource FontFamily="FA" 
                                 Glyph="&#xe922;"
				 Color="Blue"
                                 Size="25"/>
            </ShellContent.Icon>

		</ShellContent>
		<ShellContent Title="Items"  ContentTemplate="{DataTemplate local:MainPage}">
			<ShellContent.Icon>
                <FontImageSource FontFamily="FA"
				 Color="red"
                                 Glyph="&#xe922;" 
                                 Size="25"/>
            </ShellContent.Icon>
		</ShellContent>
	</TabBar>

@ReamsIT-Darren
Copy link
Author

I have tested it now with the latest version and the issue seems to be fixed. Thanks

@dotnet-policy-service dotnet-policy-service bot removed the s/try-latest-version Please try to reproduce the potential issue on the latest public version label Jun 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout area-fonts Custom fonts and Font related API's fixed-in-9.0.0-rc.2.24503.2 migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert platform/iOS 🍎 potential-regression This issue described a possible regression on a currently supported version., verification pending s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
7 participants