Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Convert Modal Implementation over to using Dialog Fragment #22587

Closed
PureWeen opened this issue May 22, 2024 · 0 comments · Fixed by #22869
Closed

[Android] Convert Modal Implementation over to using Dialog Fragment #22587

PureWeen opened this issue May 22, 2024 · 0 comments · Fixed by #22869

Comments

@PureWeen
Copy link
Member

Description

Right now we use a somewhat awkward mechanism to do modals in android. We basically add a view to the decor view on top of everything. This requires a ton of custom code to make sure everything operates successfully.

I'm fairly sure if we just switched to Dialog Fragments we could remove most of that code and then it would all just work more naturally.

I have a branch here

That mostly works but just needs a bit more testing and cleanup

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants