Dotnet 9 Memory leaks: BindableLayout leaks if nested inside a CollectionView, CarouselView ...etc

[GUELIANEBelkacem]

Description

After updating to .Net 9, i have 2 new memory leak behaviors:

1 ViewModel never removed if it contains a collection that is the ItemsSource of some control:**

If a ViewModel, which is the BindingContext of a page, contains a collection (List, ObservableCollection ..etc), and that collection is bound to the ItemsSource of a control (BindableLayout, CollectionView ...etc) ====> The ViewModel is never garbage collected !

I would like to specify that the control in question IS garbage collected, no issues on the display level, it's the ViewModel itself that stays in memory

This bahavior is consistent across platforms (tested Android, IOS and Windows)

To be ignored i was just a mistake on my part ^^'

2 BindableLayout nested inside another control such as CarouselView, CollectionView or another BindableLayout is never garbage collected

In this case, not only the ViewModel remains in memory, but the BindableLayout (Grid, AbsoluteLayout, StackLayout...whatever) and, of course, this leak cascades and THE ENTIRE PAGE remains in memory!!!!

This behavior is only reproducable on IOS, on Android and Windows the page is garbage collected

Might be important: The combo CollectionView inside CollectionView doesn's cause an issue, only BindableLayout inside some other collection (in my example it's a BindableLayout inside a CarouselView)

Steps to Reproduce

1. Clone the attached project and run
2. The first issue (ViewModel leak) can be reproduced with the 2 first button (observe that, even though the pages are collected, the ViewModel itself is still in memory)
3. The second issue (Entire page leak) can be reproduced with the 3rd button (observe that the entire page stays in memory as we have a HorizontalStackLayout with BindableLayout inside a CarouselView)

Link to public reproduction project repository

https://github.com/GUELIANEBelkacem/BindableLayoutLeakyApp.git

Version with bug

9.0.10 SR1

Is this a regression from previous behavior?

Yes, this used to work in .NET MAUI

Last version that worked well

8.0.92 SR9.2

Affected platforms

iOS, Android, Windows

Affected platform versions

Latest

Did you find any workaround?

Quit my job :)

Relevant log output

[similar-issues-ai]

We've found some similar issues:

• Memory leaks EVERYWHERE #12039 , similarity score: 82%

If any of the above are duplicates, please consider closing this issue out and adding additional context in the original issue.

Note: You can give me feedback by 👍 or 👎 this comment.

[OvrBtn]

Took a quick look and if I'm looking at this right every ViewModel is being held alive by the infinite task running on worker thread

Adding simple flag in ViewModel and changing it from Page's OnNavigatedFrom results in the issue being gone

2024-11-22.01-59-34.mp4

Please correct me if I'm wrong 😅

[GUELIANEBelkacem]

Ah yes, sorry for that it makes perfect sense. The first issue wasn't something i noticed in production code only in the test project and i found it very weird. Thank you very much!

That leaves us with the second IOS issue then (that drove me to create the test project in the first place)