Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Essentials references Xamarin in areas (docs/android file providers) #4192

Closed
jamesmontemagno opened this issue Jan 18, 2022 · 2 comments · Fixed by #4211
Closed

Essentials references Xamarin in areas (docs/android file providers) #4192

jamesmontemagno opened this issue Jan 18, 2022 · 2 comments · Fixed by #4211
Labels
area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info fixed-in-6.0.200-preview.13.2 Look for this fix in 6.0.200-preview.13.2! platform/android 🤖 platform/iOS 🍎 platform/macOS 🍏 macOS / Mac Catalyst platform/windows 🪟 t/bug Something isn't working

Comments

@jamesmontemagno
Copy link
Member

Description

There are a lot of places where xamarin is still referenced in some places and can have reference issues where Xamarin.Essentials run into conflicts.

https://github.com/dotnet/maui/tree/main/src/Essentials

Steps to Reproduce

1.) Search for xamarin in the Essentials directory

Version with bug

Preview 12 (current)

Last version that worked well

Unknown/Other

Affected platforms

iOS, Android, Windows, macOS

Affected platform versions

All

Did you find any workaround?

No response

Relevant log output

No response
@jamesmontemagno jamesmontemagno added the t/bug Something isn't working label Jan 18, 2022
@jsuarezruiz jsuarezruiz added the area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info label Jan 19, 2022
@Redth Redth mentioned this issue Jan 19, 2022
Merged
@profix898
Copy link

Preferences and SecureStorage in Essentials still use {AppInfo.PackageName}.xamarinessentials.{feature} and {AppInfo.PackageName}.xamarinessentials as name for their storage. Would be good to rename before people start using it in production apps. (Note: Preferences.GetPrivatePreferencesSharedName is also used in VersionTracking.)

@Redth
Copy link
Member

Redth commented Jan 20, 2022

Thanks, nice catch, fixed in: 45adf17

@Redth Redth closed this as completed Jan 20, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Feb 20, 2022
@samhouts samhouts added the fixed-in-6.0.200-preview.13.2 Look for this fix in 6.0.200-preview.13.2! label Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info fixed-in-6.0.200-preview.13.2 Look for this fix in 6.0.200-preview.13.2! platform/android 🤖 platform/iOS 🍎 platform/macOS 🍏 macOS / Mac Catalyst platform/windows 🪟 t/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename old Xamarin -> MAUI android resource/provider dotnet/maui
5 participants
@Redth @jamesmontemagno @profix898 @jsuarezruiz @samhouts