Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing a Windows app doesn't produce an msix #5884

Closed
eerhardt opened this issue Apr 7, 2022 · 2 comments · Fixed by #6262
Closed

Publishing a Windows app doesn't produce an msix #5884

eerhardt opened this issue Apr 7, 2022 · 2 comments · Fixed by #6262
Assignees
Labels
area-publishing Issues with the app packaging/publishing process (ipk/apk/msix/trimming) fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3! platform/windows 🪟 s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone

Comments

@eerhardt
Copy link
Member

eerhardt commented Apr 7, 2022

Description

When I try to publish a Maui Windows app, it doesn't produce an msix. My understanding is that by default a Maui Windows app is a "packaged" app. So publishing the app for Windows should produce an msix.

Steps to Reproduce

  1. dotnet new maui
  2. Temporary workaround to bring in the 1.0.2 windows sdk. Add the following to the .csproj:
	<ItemGroup>
	  <PackageReference Condition="$(TargetFramework.Contains('-windows'))"
	                    Include="microsoft.windowsappsdk"
						Version="1.0.2" />
	</ItemGroup>
  1. dotnet publish -f net6.0-windows10.0.19041.0 -c Release

Inspect the publish folder. It should contain an msix file.

Version with bug

Unknown/Other (please specify)

Last version that worked well

Unknown/Other

Affected platforms

Windows

Affected platform versions

All Windows

Did you find any workaround?

No response

Relevant log output

No response

@eerhardt eerhardt added t/bug Something isn't working s/needs-verification Indicates that this issue needs initial verification before further triage will happen labels Apr 7, 2022
@Redth Redth added this to the 6.0.300 milestone Apr 7, 2022
@Redth
Copy link
Member

Redth commented Apr 7, 2022

@marb2000 @mattleibow let's discuss this in our next sync again.

We could add some opinionated default properties in MAUI but as we discussed maybe it's better to get them into the WindowsAppSDK so that the experience is consistent with and without MAUI projects using WASDK.

One idea is that we could condition these opinionated defaults based on dotnet build vs msbuild if that's a concern.

@Redth Redth added s/verified Verified / Reproducible Issue ready for Engineering Triage platform/windows 🪟 area-publishing Issues with the app packaging/publishing process (ipk/apk/msix/trimming) and removed s/needs-verification Indicates that this issue needs initial verification before further triage will happen labels Apr 7, 2022
@mattleibow
Copy link
Member

Maybe somethings like this could help:

<PropertyGroup Condition=" '$(Target)' == 'Publish' And '$(MSBuildRuntimeType)' == 'Core' And '$(Configuration)' == 'Release' ">
    <PublishAppxPackage Condition=" '$(PublishAppxPackage)' == '' ">True</PublishAppxPackage>
</PropertyGroup>

@mattleibow mattleibow modified the milestones: 6.0.300, 6.0.300-rc.2 Apr 20, 2022
@Redth Redth modified the milestones: 6.0.300-rc.2, 6.0.300-rc.3 Apr 20, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 22, 2022
@samhouts samhouts added the fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3! label Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-publishing Issues with the app packaging/publishing process (ipk/apk/msix/trimming) fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3! platform/windows 🪟 s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants