Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] MauiSplashScreen BaseSize doesn't work #7304

Closed
janseris opened this issue May 18, 2022 · 2 comments
Closed

[Android] MauiSplashScreen BaseSize doesn't work #7304

janseris opened this issue May 18, 2022 · 2 comments
Labels
area-single-project Splash Screen, Multi-Targeting, MauiFont, MauiImage, MauiAsset, Resizetizer platform/android 🤖 s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working

Comments

@janseris
Copy link

Description

https://docs.microsoft.com/en-us/dotnet/maui/user-interface/images/splashscreen

The base size of the splash screen can be specified by setting the BaseSize attribute to values that are divisible by 8:
If you don't specify a BaseSize for a bitmap-based splash screen, the image isn't resized.

From this, I assumed that if you specify a BaseSize for a bitmap-based image, the image is resized.

However, BaseSize does nothing on Android for me.
The image does not even fit screen, it overflows the screen.

image

Image:
bird

Code:

<MauiSplashScreen Include="Resources\bird.png" Color="Green" BaseSize="128,128"/>

or 128,160 to preserve original image aspect ratio

Steps to Reproduce

Specify BaseSize attribute on MauiSplashScreen tag in .csproj when using a non-vector image.

Version with bug

Release Candidate 3 (current)

Last version that worked well

Unknown/Other

Affected platforms

Android

Affected platform versions

Android 11

Did you find any workaround?

No response

Relevant log output

No response

@janseris janseris added s/needs-verification Indicates that this issue needs initial verification before further triage will happen t/bug Something isn't working labels May 18, 2022
@kristinx0211 kristinx0211 added s/verified Verified / Reproducible Issue ready for Engineering Triage and removed s/needs-verification Indicates that this issue needs initial verification before further triage will happen labels May 19, 2022
@kristinx0211
Copy link

verified repro on android 11. repro project:
MauiApp29.zip

@Eilon Eilon added the area-single-project Splash Screen, Multi-Targeting, MauiFont, MauiImage, MauiAsset, Resizetizer label May 19, 2022
@mattleibow mattleibow self-assigned this May 19, 2022
@mattleibow mattleibow removed their assignment Aug 3, 2022
@mattleibow mattleibow added this to the .NET 7 Planning milestone Aug 3, 2022
@mattleibow
Copy link
Member

This is fixed in #8020 and BaseSize now controls the maximum size the image can be.

@mattleibow mattleibow closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-single-project Splash Screen, Multi-Targeting, MauiFont, MauiImage, MauiAsset, Resizetizer platform/android 🤖 s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants