IsEnabled doesn't update visual state after being updated with INotifyPropertyChanged when displaying shell alert on Windows 10

[Laradius]

Description

Visual state of button doesn't change after alert is displayed despite being enabled. It's visible as disable despite being clickable.

It works fine on Android.

ObservableProperty and ICommand is part of Microsoft.Toolkit.Mvvm.ComponentModel

        [ObservableProperty]
        [AlsoNotifyChangeFor(nameof(IsNotBusy))]
        private bool isBusy;
        public bool IsNotBusy => !IsBusy;

<Button Text="DisplayCommand" Command="{Binding DisplayAlertCommand}" IsEnabled="{Binding IsNotBusy}">

[ICommand]
public async Task DisplayAlertAsync()
        {
            IsBusy = true;
            bool answer = await Shell.Current.DisplayAlert("Question?", "Would you like to play a game", "Yes", "No");
            IsBusy = false;
        }

Steps to Reproduce

1. Run app on Windows 10
2. Click button
3. Visual state doesn't update after alert is displayed.

Version with bug

6.0.419 (current)

Last version that worked well

Unknown/Other

Affected platforms

Windows

Affected platform versions

Windows 10

Did you find any workaround?

No response

Relevant log output

No response

[ghost]

Hi @Laradius. We have added the "s/needs-repro" label to this issue, which indicates that we require steps and sample code to reproduce the issue before we can take further action. Please try to create a minimal sample project/solution or code samples which reproduce the issue, ideally as a GitHub repo that we can clone. See more details about creating repros here: https://github.com/dotnet/maui/blob/main/.github/repro.md

This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

[ghost]

This issue has been automatically marked as stale because it has been marked as requiring author feedback to reproduce the issue but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. If it is closed, feel free to comment when you are able to provide the additional information and we will re-investigate.

[Laradius]

https://github.com/Laradius/MauiErrorApp

[Laradius]

@Eilon @rmarinho Could I get informatiom regarding that issue?

[Eilon]

@Laradius we will check this out in an upcoming bug triage meeting. I'm wondering if the async behavior is somehow affecting this? I'm not sure how the MVVM Toolkit attributes work with this, either. What happens if you call NotifyPropertyChanged(nameof(IsNotBusy)) after setting it to false?

[Laradius]

@Laradius we will check this out in an upcoming bug triage meeting. I'm wondering if the async behavior is somehow affecting this? I'm not sure how the MVVM Toolkit attributes work with this, either. What happens if you call NotifyPropertyChanged(nameof(IsNotBusy)) after setting it to false?

Is not busy property returns true and notifies all bindings about the change.

[Ahmadmansoor]

Hi
I have already posted this at another repo
CommunityToolkit/dotnet#372
my problem is the button can't disable itself from the C# code.
and sometimes from the other buttons as well.
any guide pls, my whole work is stope at this stage.

[sude22]

Do anybody care about this issue?
Right now it is not possible to use Async Commands for buttons because the visual state of the button (from CanExecute) may be not correct after showing a DisplayAlert. A showstopper in the moment for MAUI on Windows.....

[hartez]

Possibly related: #9753

[ghost]

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

[PureWeen]

Possibly related CommunityToolkit/dotnet#316

[Sergio0694]

I've noticed the same in MAUI as well (it does indeed look related to #9753). This seems to be a MAUI specific issue and unrelated from the MVVM Toolkit per se (the same code works just fine on UWP and WinUI 3 too, for instance).

@Laradius unrelated, but you can simplify your code by removing those IsBusy/IsNotBusy properties entirely, and just bind to the IsRunning property exposed by the IAsyncRelayCommand property that the generator will create for you. For the inverted property (IsNotBusy), simply use a converter or x:Bind to function in XAML, you don't need an extra property 🙂

[hartez]

This was fixed by #11840.