-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert all uses of UICommand to UIAction #9332
Comments
One thing I'm not sure of is that with the selector stuff and UICommand, it might be easier to integrate with the default MacOS menus that nearly every app has, like File/Edit/View. I'm not sure if that works with UIAction. Definitely something to consider. |
I did a basic test just plopping in AFAICT the only difference between the two is that one uses a closure and the other uses a selector Still haven't found anything indicating the why of doing one vs the other. |
Description
OnHold until: https://github.com/dotnet/maui/pull/14740/files/49f5f1f0685a17e332d3d67e4f654a605ccdae47#diff-f1798675642557df37437c1b2586c65818edf78c04b02740ff587e2d3486fc0fR50
Currently for Menus on Catalyst we are using
UICommand
's which requires selectors. This leads to a lot of awkward extra code. It appears that we can just useUIAction
instead.The text was updated successfully, but these errors were encountered: