Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Catalyst] Adding and Removing ContextMenus currently does not work #9359

Open
2 tasks done
Tracked by #9139
PureWeen opened this issue Aug 11, 2022 · 2 comments
Open
2 tasks done
Tracked by #9139

[Catalyst] Adding and Removing ContextMenus currently does not work #9359

PureWeen opened this issue Aug 11, 2022 · 2 comments
Assignees
@Eilon @PureWeen @lizharems
Labels
area-controls-contextmenu ContextMenu blocked Work that is currently blocked p/2 Work that is important, but is currently not scheduled for release partner/cat 😻 this is an issue that impacts one of our partners or a customer our advisory team is engaged with platform/macOS 🍏 macOS / Mac Catalyst s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working t/desktop The issue relates to desktop scenarios (MacOS/MacCatalyst/Windows/WinUI/WinAppSDK)
Milestone
.NET 10 Planning

Comments

@PureWeen
Copy link
Member

PureWeen commented Aug 11, 2022 •
edited by samhouts
Loading

Description

The code needs to be filled in for adding/removing Context Menus

  • Windows it kind of works. If you test the controls sample it sometimes adds one sub menu item but then others don't get added
  • Catalyst completely doesn't work

On catalyst I found that the issue is related to not disconnecting the handler before recreating the menu.

Workaround

You can pretty easily fix it by adding the following disconnect code

image

But after I did that the behavior of the ContextMenu on the WkWebView became more erratic

Depends on

VS bug #1816116
@PureWeen PureWeen added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Aug 11, 2022
@PureWeen PureWeen added this to the .NET 7 milestone Aug 11, 2022
@PureWeen PureWeen mentioned this issue Aug 11, 2022
Merged
@samhouts samhouts added t/bug Something isn't working legacy-area-desktop Windows / WinUI / Project Reunion & Mac Catalyst / macOS specifics (Menus & other Controls)) area-controls-contextmenu ContextMenu labels Aug 31, 2022
@mattleibow mattleibow mentioned this issue Sep 2, 2022
Open
22 tasks
@PureWeen PureWeen modified the milestones: .NET 7 Planning, 7.0 Sep 28, 2022
@Eilon Eilon mentioned this issue Oct 8, 2022
Open
@Eilon Eilon added platform/windows 🪟 partner/winui WinUI / Project Reunion platform/macOS 🍏 macOS / Mac Catalyst labels Oct 8, 2022
@Eilon
Copy link
Member

Eilon commented Oct 8, 2022

Windows already partially works but has a bug in WinUI: You can add new top-level items and they work fine. But if you add items to a sub-menu, they do not appear at all. This repros in a pure WinUI app, per microsoft/microsoft-ui-xaml#7797.

@Redth Redth modified the milestones: 7.0, .NET 7 + Servicing Oct 12, 2022
@mikeparker104 mikeparker104 added the partner/cat 😻 this is an issue that impacts one of our partners or a customer our advisory team is engaged with label Dec 16, 2022
@samhouts samhouts added the p/1 Work that is important, and has been scheduled for release in this or an upcoming sprint label Dec 17, 2022
@samhouts samhouts added blocked Work that is currently blocked external labels May 2, 2023
@PureWeen PureWeen changed the title Adding and Removing ContextMenus currently does not work [Catalyst] Adding and Removing ContextMenus currently does not work May 8, 2023
@Redth Redth modified the milestones: .NET 8 Planning, .NET 8 GA Jul 12, 2023
@lizharems lizharems self-assigned this Sep 6, 2023
@Zhanglirong-Winnie Zhanglirong-Winnie added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Dec 19, 2023
@Zhanglirong-Winnie
Copy link

Verified this issue with VSM 17.6.7 (build 417). Can repro this issue.

@Eilon Eilon added t/desktop The issue relates to desktop scenarios (MacOS/MacCatalyst/Windows/WinUI/WinAppSDK) and removed legacy-area-desktop Windows / WinUI / Project Reunion & Mac Catalyst / macOS specifics (Menus & other Controls)) legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor labels May 10, 2024
@PureWeen PureWeen added p/2 Work that is important, but is currently not scheduled for release and removed p/1 Work that is important, and has been scheduled for release in this or an upcoming sprint labels Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eilon Eilon

@PureWeen PureWeen

@lizharems lizharems

Labels
area-controls-contextmenu ContextMenu blocked Work that is currently blocked p/2 Work that is important, but is currently not scheduled for release partner/cat 😻 this is an issue that impacts one of our partners or a customer our advisory team is engaged with platform/macOS 🍏 macOS / Mac Catalyst s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working t/desktop The issue relates to desktop scenarios (MacOS/MacCatalyst/Windows/WinUI/WinAppSDK)
Projects
None yet
Milestone
.NET 10 Planning
Development

No branches or pull requests
7 participants
@Eilon @Redth @PureWeen @samhouts @mikeparker104 @Zhanglirong-Winnie @lizharems