Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not change the changewave optout #11171

Closed
JanKrivanek opened this issue Dec 18, 2024 · 1 comment
Closed

Do not change the changewave optout #11171

JanKrivanek opened this issue Dec 18, 2024 · 1 comment
Assignees
Labels

Comments

@JanKrivanek
Copy link
Member

Motivation

ChangeWave optout should be tailored to optout of a specific behavior - let's not "auto-bump" the optout to newer waves automatically. This can lead to unexpected changes in behavior

Sample case

##[warning]Environment variable MSBUILDDISABLEFEATURESFROMVERSION is set to a version that is out of rotation. Defaulting to Change Wave version: 17.10. Entered value: 17.6. Current Change Waves: [17.10, 17.12].

Expected Behavior

Specifying old changewave doesn't have any effect

Actual behavior

Specifying old changewave opts out of newer behavior

@JanKrivanek
Copy link
Member Author

Discussed offline with @rainersigwald - we cannot simply change the behavior as there might be existing users explicitly counting on a fact that specifying changewave optout applies to all newer changewaves as well and carries forward to the future (so even specifying very old - long long removed - changewave is a way to opt out a new behavior).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants