Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging in RAR for FoundConflicts #1996

Closed
KirillOsenkov opened this issue Apr 19, 2017 · 1 comment
Closed

Improve logging in RAR for FoundConflicts #1996

KirillOsenkov opened this issue Apr 19, 2017 · 1 comment
Labels
Area: Debuggability Issues impacting the diagnosability of builds, including logging and clearer error messages. Area: Logging triaged

Comments

@KirillOsenkov
Copy link
Member

KirillOsenkov commented Apr 19, 2017

In case there was at least one unresolvable conflict we just log a generic message instead of more detailed message that would help diagnose the problem:
http://source.dot.net/#Microsoft.Build.Tasks.Core/AssemblyDependency/ResolveAssemblyReference.cs,1040
http://source.dot.net/#Microsoft.Build.Tasks.Core/AssemblyDependency/ResolveAssemblyReference.cs,1064

My understanding is that we should be logging the idealRemappingPartialAssemblyName. I think this is the situation where the version of the chosen assembly is smaller than the victims because it was primary:

...\Microsoft.Common.CurrentVersion.targets(1826,5): warning MSB3277: Found conflicts between different versions of the same dependent assembly that could not be resolved.  These reference conflicts are listed in the build log when log verbosity is set to detailed.]
There was a conflict between "Microsoft.WindowsAzure.Storage, Version=6.1.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35" and "Microsoft.WindowsAzure.Storage, Version=7.2.1.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35". (TaskId:2007)
"Microsoft.WindowsAzure.Storage, Version=6.1.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35" was chosen because it was primary and "Microsoft.WindowsAzure.Storage, Version=7.2.1.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35" was not. (TaskId:2007)

Reported by Aleks Gershaft from Microsoft.

@KirillOsenkov KirillOsenkov added Area: Debuggability Issues impacting the diagnosability of builds, including logging and clearer error messages. Area: Logging labels Apr 9, 2020
@KirillOsenkov
Copy link
Member Author

I believe this has been fixed by:
#2379
#5798
#5990

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Debuggability Issues impacting the diagnosability of builds, including logging and clearer error messages. Area: Logging triaged
Projects
None yet
Development

No branches or pull requests

2 participants