Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAR] As a customer, I want implicitly cached references so that MSBUILD builds faster #3139

Closed
6 of 8 tasks
Tracked by #5876
rainersigwald opened this issue Mar 27, 2018 · 10 comments
Closed
6 of 8 tasks
Tracked by #5876
Assignees
Labels
Abandoned bot-exclude Bots should explicitly ignore this issue/PR Cost:M Work that requires one engineer up to 2 weeks performance Performance-Scenario-Build This issue affects build performance. Priority:1 Work that is critical for the release, but we could probably ship without test triaged User Story A single user-facing feature. Can be grouped under an epic.
Milestone

Comments

@rainersigwald
Copy link
Member

rainersigwald commented Mar 27, 2018

RAR (Resolve Assembly References) as a service.

We have many issues related to the fact that ResolveAssemblyReferences a) must run for every build, including no-op incremental builds and b) is slow.

Creating a long-lived process as a cache for assembly information and so on could have a big impact on build perf, including design-time builds.

Note: This is a draft/proposed user story and not committed for .NET 6.0 yet.

Issues:

@rainersigwald rainersigwald added needs-design Requires discussion with the dev team before attempting a fix. performance labels Mar 27, 2018
@rainersigwald rainersigwald added this to the MSBuild 15.8 milestone Mar 27, 2018
@rainersigwald rainersigwald removed this from the MSBuild 15.8 milestone Jun 7, 2018
@rainersigwald
Copy link
Member Author

Any further work on this should be based on #3914.

@panopticoncentral panopticoncentral added the Performance-Scenario-Build This issue affects build performance. label Jun 9, 2020
@mfkl
Copy link
Contributor

mfkl commented Jun 27, 2020

Are there any future plans to revive the following PRs #3914 and #3868?

@ostorc
Copy link
Contributor

ostorc commented Jul 14, 2020

I have just started working on this issue.

@ladipro
Copy link
Member

ladipro commented Jul 29, 2020

The work is tracked as a project: https://github.com/dotnet/msbuild/projects/35

@am11
Copy link
Member

am11 commented Aug 2, 2020

The spec document suggests that Bond has been discontinued (therefore PR #3914 was not completed):

There was already an attempt to introduce RAR as a service to MSBuild ([#3914](https://github.com/dotnet/msbuild/pull/3914)). This PR was not completed mainly because of discontinued development of Bond, which is in that PR used as method of communication between nodes.

Is it correct? I could not find any reference to Bond being discontinued. The latest release was made just 19 days ago: https://github.com/microsoft/bond/releases (brew install bond gave me the latest v9.0.1 of Bond on macOS).

@ostorc
Copy link
Contributor

ostorc commented Aug 2, 2020

I was also confused by that. But it was pointed out to me, that this is some unusual activity in that repo (https://github.com/microsoft/bond/graphs/code-frequency).

@ostorc ostorc added the Epic Groups multiple user stories. Can be grouped under a theme. label Aug 4, 2020
@ostorc
Copy link
Contributor

ostorc commented Aug 4, 2020

Note: I have converted issue to epic, for tracking purposes

@donJoseLuis donJoseLuis assigned AR-May and unassigned ostorc Oct 19, 2020
@donJoseLuis donJoseLuis changed the title RAR as a service As a customer, I want to cache references so that builds are faster. Nov 6, 2020
@donJoseLuis donJoseLuis changed the title As a customer, I want to cache references so that builds are faster. As a customer, I want to cache references so that MSBUILD builds faster. Nov 6, 2020
@donJoseLuis donJoseLuis added User Story A single user-facing feature. Can be grouped under an epic. Priority:1 Work that is critical for the release, but we could probably ship without and removed Epic Groups multiple user stories. Can be grouped under a theme. labels Nov 6, 2020
@donJoseLuis donJoseLuis changed the title As a customer, I want implicitly cached references so that MSBUILD builds faster [RAR] As a customer, I want implicitly cached references so that MSBUILD builds faster Apr 9, 2021
@donJoseLuis donJoseLuis added bot-test Bots should use this label for testing. test labels Jun 26, 2021
@ghost ghost added the stale For issues that haven't had activity in some time. label Jun 28, 2021
@ghost
Copy link

ghost commented Jun 28, 2021

This issue is marked as stale because feedback has been requested for 30 days with no response. Please respond within 14 days or this issue will be closed due to inactivity.

@Saibamen
Copy link

        .

@ghost ghost added needs-attention Needs a member of the team to respond. and removed stale For issues that haven't had activity in some time. labels Jun 28, 2021
@benvillalobos benvillalobos added bot-exclude Bots should explicitly ignore this issue/PR and removed bot-test Bots should use this label for testing. needs-attention Needs a member of the team to respond. labels Jun 28, 2021
@donJoseLuis
Copy link

The early performance numbers did not merit continuing on this delivery thread. Thus, we are parking this user story.

@donJoseLuis donJoseLuis self-assigned this Aug 3, 2021
@donJoseLuis donJoseLuis reopened this Aug 9, 2021
@ladipro ladipro added this to the VS 17.0 milestone Dec 9, 2021
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Abandoned bot-exclude Bots should explicitly ignore this issue/PR Cost:M Work that requires one engineer up to 2 weeks performance Performance-Scenario-Build This issue affects build performance. Priority:1 Work that is critical for the release, but we could probably ship without test triaged User Story A single user-facing feature. Can be grouped under an epic.
Projects
None yet
Development

No branches or pull requests

10 participants