Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.Build.Commontypes.xsd contains PackageTargetFallback but not AssetTargetFallback #3292

Closed
ericstj opened this issue May 9, 2018 · 3 comments
Labels
Milestone

Comments

@ericstj
Copy link
Member

ericstj commented May 9, 2018

/cc @mairaw @emgarten @dsplaisted
Related dotnet/docs#2816

I believe we recommend using AssetTargetFallback over PackageTargetFallback since it behaves better considering the entire package's asset groups rather than just evaluating it independently.

@rainersigwald rainersigwald added this to the MSBuild 15.8 milestone May 9, 2018
@emgarten
Copy link
Member

emgarten commented May 9, 2018

//cc @mishra14

@dsplaisted
Copy link
Member

I'd suggest removing PackageTargetFallback from the intellisense, since it can behave in ways you wouldn't expect.

I'm not sure at this point whether we should add AssetTargetFallback to the intellisense though. Hopefully by now it's not common to need to use it (we set it automatically to enable referencing .NET Framework projects from .NET Core / .NET Standard, but that doesn't mean people need to put it in their projects).

@rainersigwald
Copy link
Member

It'll be required to support build-only (no reference) ProjectReferences, unfortunately, so I think it probably needs to go in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants