Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't materialize LazyFormattedBuildEventArgs.Message in packet serializer and binary logger #6199

Closed
KirillOsenkov opened this issue Feb 26, 2021 · 1 comment
Closed

Don't materialize LazyFormattedBuildEventArgs.Message in packet serializer and binary logger #6199

KirillOsenkov opened this issue Feb 26, 2021 · 1 comment
Assignees
@KirillOsenkov
Labels
Area: Logging performance Performance-Scenario-Build This issue affects build performance. Priority:2 Work that is important, but not critical for the release triaged
Milestone
MSBuild 16.10

Comments

@KirillOsenkov
Copy link
Member

We can just write the raw message and args instead of realizing the long string unnecessarily. This should help with binlog size (as smaller strings are more reusable) and memory allocations.
@KirillOsenkov KirillOsenkov added performance Performance-Scenario-Build This issue affects build performance. Area: Logging needs-triage Have yet to determine what bucket this goes in. labels Feb 26, 2021
@KirillOsenkov KirillOsenkov self-assigned this Feb 26, 2021
@KirillOsenkov
Copy link
Member Author

Consider the same for ProjectImported, TargetSkipped, Property Reassignment

@AR-May AR-May removed the needs-triage Have yet to determine what bucket this goes in. label Mar 4, 2021
@panopticoncentral panopticoncentral added the Priority:2 Work that is important, but not critical for the release label Mar 23, 2021
@KirillOsenkov KirillOsenkov mentioned this issue Apr 5, 2021
Merged
@ladipro ladipro added this to the MSBuild 16.10 milestone Dec 8, 2021
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KirillOsenkov KirillOsenkov

Labels
Area: Logging performance Performance-Scenario-Build This issue affects build performance. Priority:2 Work that is important, but not critical for the release triaged
Projects
None yet
Milestone
MSBuild 16.10
Development

No branches or pull requests
4 participants
@KirillOsenkov @panopticoncentral @ladipro @AR-May