Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate SDK test failures and finalize "enable producing reference assemblies by default" #8133

Closed
rokonec opened this issue Nov 4, 2022 · 2 comments
Closed

Investigate SDK test failures and finalize "enable producing reference assemblies by default" #8133

rokonec opened this issue Nov 4, 2022 · 2 comments
Assignees
@YuliiaKovalova
Labels
Area-NetSDK triaged

Comments

@rokonec
Copy link
Member

rokonec commented Nov 4, 2022

We have reverted #8111.
See #8131 for more details.
Related failing SDK insertion PR was dotnet/sdk#28869

We shall either fix in msbuild or find out how to fix test in SDK.
@drewnoakes drewnoakes mentioned this issue Apr 5, 2023
Merged
@drewnoakes
Copy link
Member

This has been fixed.

@rainersigwald
Copy link
Member

Note that I've recieved a couple of offline reports of trouble from this that make me suspect we'll have to revert again, but we're not quite there yet.

@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YuliiaKovalova YuliiaKovalova

Labels
Area-NetSDK triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@drewnoakes @rainersigwald @rokonec @AR-May @YuliiaKovalova