Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider redacting username in binlogs #8493

Open
rainersigwald opened this issue Feb 23, 2023 · 2 comments
Open

Consider redacting username in binlogs #8493

rainersigwald opened this issue Feb 23, 2023 · 2 comments
Labels

Comments

@rainersigwald
Copy link
Member

Idea from @grendello on Discord:

however, @rainersigwald it would be nice if binlog masked the user's home directory path
it reveals login name
it's especially important on servers
it gives you a known existing account name
$HOME should be replaced with ~ or something like that

@rainersigwald rainersigwald added Area: Logging needs-triage Have yet to determine what bucket this goes in. labels Feb 23, 2023
@AR-May AR-May added Priority:3 Work that is nice to have backlog and removed needs-triage Have yet to determine what bucket this goes in. labels Mar 29, 2023
@JanKrivanek
Copy link
Member

Related to #8400
Though removing the home folder from logs via events redacting would very likely be significantly impacting performance. The ideal solution would emit the replacement log at the places where we know the home folder is being introduced or used - there are however far too many and many of those are simple properties assignments - e.g.:

@JanKrivanek JanKrivanek removed their assignment Mar 30, 2023
@JanKrivanek
Copy link
Member

@grendello - while not built-in, you can achieve this now with the binlog viewer: KirillOsenkov/MSBuildStructuredLog#711 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants