Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Kitten] Remove APICompat workaround once 8.0.2 or 9.xxx is consumed #9720

Closed
Tracked by #10280
JanKrivanek opened this issue Feb 8, 2024 · 1 comment · Fixed by #9791
Closed
Tracked by #10280

[Kitten] Remove APICompat workaround once 8.0.2 or 9.xxx is consumed #9720

JanKrivanek opened this issue Feb 8, 2024 · 1 comment · Fixed by #9791
Assignees
@f-alizada
Labels
Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself. triaged

Comments

@JanKrivanek
Copy link
Member

Not actionable now - logged not to forget about this.

Background

A workaround for clashing version of Roslyn and APICompat checker needed to be introduced:
https://github.com/dotnet/msbuild/pull/9642/files#diff-50e91c82311ea26f2a73202525dfdf2b0a89c178ee666b2bf3ad4c84ac4c06dcR41

Once we update our build-time dotnet version (https://github.com/dotnet/msbuild/blob/main/global.json#L6) we should remove the workaround.
@AR-May AR-May added Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself. triaged labels Feb 13, 2024
@JanKrivanek JanKrivanek mentioned this issue Feb 28, 2024
Merged
@JanKrivanek JanKrivanek reopened this Feb 28, 2024
@JanKrivanek JanKrivanek changed the title Remove APICompat workaround once 8.0.2 or 9.xxx is consumed [Kitten] Remove APICompat workaround once 8.0.2 or 9.xxx is consumed Feb 28, 2024
@JanKrivanek JanKrivanek mentioned this issue Jul 23, 2024
Closed
6 tasks
This was referenced Aug 2, 2024
Closed
Merged
@f-alizada f-alizada self-assigned this Aug 31, 2024
@f-alizada
Copy link
Contributor

This is removed as part of the PR : https://github.com/dotnet/msbuild/pull/10484/files#diff-50e91c82311ea26f2a73202525dfdf2b0a89c178ee666b2bf3ad4c84ac4c06dc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@f-alizada f-alizada

Labels
Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself. triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove api compat workaround dotnet/msbuild
4 participants
@JanKrivanek @MichalPavlik @AR-May @f-alizada