Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to stamp package.json with nbgv version #6

Closed
AArnott opened this issue Aug 18, 2019 · 2 comments · Fixed by #24
Closed

Add option to stamp package.json with nbgv version #6

AArnott opened this issue Aug 18, 2019 · 2 comments · Fixed by #24
Labels
enhancement New feature or request

Comments

@AArnott
Copy link
Collaborator

AArnott commented Aug 18, 2019

No description provided.

@japj
Copy link

japj commented May 1, 2020

Do you have an idea yet how the gitihub action api should look for this?

I am not familiar with writing github actions, but I recently started working on a "hobby" project that I would like to use this on. So if I can help implement this please let me know

@AArnott
Copy link
Collaborator Author

AArnott commented May 2, 2020

Maybe all we need to do is document how to do it. I do it here:

https://github.com/AArnott/cloudbuild-task/blob/928bbf0706fbaa5f296c0d3177df569d882e1f3d/.github/workflows/build.yml#L45-L48

Building it into this github action as a standalone feature could work too. I'm not yet sure exactly how I would expose it. Perhaps a packageJson input that is the path to the package.json file to be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants