Skip to content
This repository has been archived by the owner on Jan 8, 2019. It is now read-only.

Split FSharp.NET.Sdk package in sdk only + targets #56

Closed
enricosada opened this issue Dec 9, 2016 · 3 comments · Fixed by #110
Closed

Split FSharp.NET.Sdk package in sdk only + targets #56

enricosada opened this issue Dec 9, 2016 · 3 comments · Fixed by #110
Assignees
Labels

Comments

@enricosada
Copy link
Contributor

enricosada commented Dec 9, 2016

ref dotnet/cli#4976

Move Sdk dir in another FSharp.NET.Sdk package version, so can be bundled in VS/cli

  • FSharp.NET.Sdk 1.0.0-bundled the part bundled in VS/cli
  • FSharp.NET.Sdk 1.0.0 the part restored from PackageReference

Name cannot be changed atm (will break templates, so lot of pain), so atm using two version can be ok (the -bundled is pinned anyway in VS/CLI).

@enricosada enricosada added this to the 1.0.0-preview5 milestone Dec 9, 2016
@enricosada enricosada self-assigned this Dec 9, 2016
@TheRealPiotrP
Copy link

👀

I hope all is well in F#!

@enricosada
Copy link
Contributor Author

@piotrpMSFT yes, the sdk part was ok, i was finishing the package (removing dotnet-compile-fsc, some cleanup, etc)
i'll fix this with dotnet/cli#5557 and more PR with new templates soon (probably i need to learn about dotnet new3 too for that 😄 )

@enricosada enricosada modified the milestones: 1.0.0-preview5, FSharp.Sdk package Feb 9, 2017
@enricosada enricosada mentioned this issue Feb 9, 2017
@enricosada enricosada reopened this Feb 16, 2017
@enricosada
Copy link
Contributor Author

moved to .net core sdk 2.0, the 1.0 is code freeze

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants