Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in silo start log #8979

Closed
kmcclellan opened this issue May 7, 2024 · 1 comment · Fixed by #8980
Closed

Typo in silo start log #8979

kmcclellan opened this issue May 7, 2024 · 1 comment · Fixed by #8980

Comments

@kmcclellan
Copy link

Orleans surfaces MachineNAme (bad casing) as a log property in structured logs, which is annoying and doesn't correlate with other logs that send MachineName.

orleans/src/Orleans.Runtime/Silo/Silo.cs

Line 128 in deda4ba

"-------------- Initializing silo on host {HostName} MachineName {MachineNAme} at {LocalEndpoint}, gen {Generation} --------------",

@ReubenBond ReubenBond mentioned this issue May 7, 2024
Merged
@ReubenBond
Copy link
Member

Thanks for notifying us, @kmcclellan - I've opened #8980

@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix capitalization of 'MachineName' structured logging parameter ReubenBond/orleans
2 participants
@ReubenBond @kmcclellan