Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Windows/arm64: 2 Improvements on 10/14/2023 8:59:45 PM #23346

Closed
performanceautofiler bot opened this issue Oct 19, 2023 · 1 comment
Closed

[Perf] Windows/arm64: 2 Improvements on 10/14/2023 8:59:45 PM #23346

performanceautofiler bot opened this issue Oct 19, 2023 · 1 comment

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Oct 19, 2023

Run Information

Name Value
Architecture arm64
OS Windows 10.0.19041
Queue SurfaceWindows
Baseline 851c274cc50544bf11a59e1011dbc594ca7010b0
Compare 139f45e56b85b7e643d7e4f81cb5cdf640cd9021
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Improvements in System.IO.Tests.BinaryReaderTests

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
36.15 ns 16.95 ns 0.47 0.37 False
52.32 ns 42.49 ns 0.81 0.03 False

graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.IO.Tests.BinaryReaderTests*'

Payloads

Baseline
Compare

System.IO.Tests.BinaryReaderTests.DefaultCtor

ETL Files

Histogram

Description of detection logic

IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed: Marked as improvement because we could not find enough baseline builds for window checking.
IsChangePoint: Marked as a change because one of 10/13/2023 7:46:10 PM, 10/18/2023 4:42:02 PM falls between 10/9/2023 8:09:24 PM and 10/18/2023 4:42:02 PM.
IsImprovementStdDev: Marked as improvement because 21.46613607901271 (T) = (0 -17.81439107223003) / Math.Sqrt((16.201961235655443 / (114)) + (3.5113653714729938 / (5))) is greater than 1.9804475986831467 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (114) + (5) - 2, .975) and 0.5254536994013029 = (37.53983762965814 - 17.81439107223003) / 37.53983762965814 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

System.IO.Tests.BinaryReaderTests.ReadSmallString

ETL Files

Histogram

Description of detection logic

IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed: Marked as improvement because we could not find enough baseline builds for window checking.
IsChangePoint: Marked as a change because one of 10/13/2023 7:46:10 PM, 10/18/2023 4:42:02 PM falls between 10/9/2023 8:09:24 PM and 10/18/2023 4:42:02 PM.
IsImprovementStdDev: Marked as improvement because 34.13223240431572 (T) = (0 -42.14396777990734) / Math.Sqrt((2.710931640093706 / (113)) + (0.23448359309270034 / (5))) is greater than 1.9806260024587088 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (113) + (5) - 2, .975) and 0.1773826858427252 = (51.23155938321268 - 42.14396777990734) / 51.23155938321268 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant