Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasm warning 'unknown flag --experimental-wasm-eh' #3399

Closed
LoopedBard3 opened this issue Oct 10, 2023 · 3 comments
Closed

Wasm warning 'unknown flag --experimental-wasm-eh' #3399

LoopedBard3 opened this issue Oct 10, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@LoopedBard3
Copy link
Member

LoopedBard3 commented Oct 10, 2023

It appears that the --experimental-wasm-eh flag we are passing to v8 is not being recognized. This is affecting both the wasm aot and wasm wasm microbenchmarks. I have not looked back to see how far back this is affecting yet. The version of v8 that was used in the run I found this is 11.7.439. I tried searching the help for this flag on version 12.0.* of v8 and am not finding it as an option so it may have been removed.

@radical, do you know if this is the proper use of the --experimental-wasm-eh flag and if the flag still exists?

@LoopedBard3 LoopedBard3 added the bug Something isn't working label Oct 10, 2023
@LoopedBard3 LoopedBard3 self-assigned this Oct 10, 2023
@LoopedBard3
Copy link
Member Author

After some digging it looks like the --experimental-wasm-eh flag may only be needed by older node versions and can be removed from our runs: dotnet/runtime#91318

@radical
Copy link
Member

radical commented Oct 11, 2023

Yeah, the versions of v8 being used in perf pipeline, and library tests were not the same earlier. But they are controlled, and in sync now to be the latest stable which shouldn't need the argument.

@LoopedBard3
Copy link
Member Author

This appears to be working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants