Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeployTestDependencies in project system solution is always unresolved for projects referencing it #1899

Closed
abpiskunov opened this issue Mar 30, 2017 · 5 comments
Assignees
Milestone

Comments

@abpiskunov
Copy link
Contributor

DeployTestDependencies has weird project file which does not have SDK , but imports ProducesNoOutput.Settings.targets . This results in several things:

  • DeployTestDependencies does not receive any evaluation or designtime builds for its References,ProjectReference etc . That is expected since i don't see any Managed.DesignTime.targets imprted there (they usually brought by SDK). This is potentially a problem for the future , when we would need support projects that don't rely on core sdk.
  • Other projects referencing DeployTestDependencies receive only evaluation (which means project is unresolved for them), but no DesignTime events with resolved project path. This is i am not sure why .. even though DeployTestDependencies does not have sdk etc , why resolution logic for other projects cannot find it? This seems like a bug we need to fix now...?
@srivatsn
Copy link
Contributor

srivatsn commented Mar 31, 2017

That is expected since i don't see any Managed.DesignTime.targets imprted there (they usually brought by SDK).

No the DesignTime.targets are brought in by CSharp.targets and not the SDK. Also ProduceNoOutput.Settings.targets internally imports the SDK. I just ran msbuild /pp on that project and it does import the SDK props\targets

@srivatsn srivatsn added this to the 15.3 milestone Mar 31, 2017
@srivatsn srivatsn added the Bug label Mar 31, 2017
@abpiskunov abpiskunov assigned srivatsn and unassigned abpiskunov Apr 4, 2017
@abpiskunov
Copy link
Contributor Author

Why me? :) It is not dependencies node - i don't receive any events as i described above, could be sdk or something else , since this project has special settings ...

@abpiskunov abpiskunov self-assigned this Apr 4, 2017
@abpiskunov
Copy link
Contributor Author

Actually, let me double check something, i will post more updates after i am done with more invcestogations

@abpiskunov
Copy link
Contributor Author

found what was the problem and fixed it in current PR, will close this issue once PR checked in

@abpiskunov
Copy link
Contributor Author

fixed with #1880

@drewnoakes drewnoakes removed the Bug label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants