Dependencies node shows with a warning icon until restore is complete

[balachir]

With Dev15.3 Preview1 builds (from d15prerel), dependencies node shows with a warning icon until restore is complete.

The warning icon eventually goes away, but it looks ugly especially for ASP.NET Core applications because it takes a long time for the warning icon to go away making me wonder that there are issues with the project that I just created. It shows up during project open as well.

[jmarolf]

@balachir this is an explicit decision to indicate to the user that the restore has not yet completed for this project.

making me wonder that there are issues with the project

There is an issue, restore has not yet completed. Would you prefer to not have any UI to indicate that a restore needs to happen? Would you prefer a different icon?

[abpiskunov]

Agree, the sign tells you that project is not ready and reasons could be: a. restore did not happen yet. Even if we make icon grey at project open, when user open it all dependencies will be yellow below it since they were not restored yet. So that would kind of meaningless. The real problem here is that restore should not happen everytime you open a project (as it does now) and slow design time builds (which need to be faster).

[SolderedMushroom]

There is an issue, restore has not yet completed.

I don't want to see a yellow warning triangle for an "issue" that will resolve itself without my help. If I see that icon in the solution explorer, I'm going to expand it to try to see what the problem is so I can fix it, and then be annoyed because it's just a package restore that's already in progress.

If it needs an icon, it should be an icon that indicates "something is in progress" or "not everything is here yet," not the universal warning symbol.

[jmarolf]

@SolderedMushroom I like the idea of showing progress. I think we need some icon to indicate that the project is not ready, but agree that the yellow warning icon is too scary.

[davkean]

In agreement, I don't like the yellow warning icon for "unrestored case".

[tmeschter]

@srivatsn @natidea What controls which icon is shown here? I would ask @abpiskunov but he's OOF for a couple of months.

[abpiskunov]

Node models control nodes properties including icons. See corresponding IDependencyModel implementations. Thanks, Anton

[abpiskunov]

Then look at dependencies tree view provider that actually applies icons logic to the tree. Btw how you would see that restore is not complete yet? Was this decided already? Thanks, Anton

[tmeschter]

So the open question is how do we know that restore is ongoing, or complete.

[tmeschter]

Doesn't meet the bar for 15.5. Moving out to 15.6.

[cartermp]

We should close this in favor of #3430 and #4362 - the first is a more specific issue tracking this problem from the perspective of what to do next (since it's a design problem), and the latter groups that into a more general proposal for the Dependencies node with .NET Core 3.0 in mind.

[drewnoakes]

@cartermp that seems sensible to me.

[drewnoakes]

This specific request is being tracked by #5044.