Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostics directly on P2P References do not display in the Dependencies node #2436

Closed
natidea opened this issue Jun 13, 2017 · 1 comment · Fixed by #6155
Closed

Diagnostics directly on P2P References do not display in the Dependencies node #2436

natidea opened this issue Jun 13, 2017 · 1 comment · Fixed by #6155
Assignees
@drewnoakes
Labels
Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references Triage-Approved Reviewed and prioritized
Milestone
16.7

Comments

@natidea
Copy link
Contributor

natidea commented Jun 13, 2017 •
edited
Loading

Steps
Create a P2P reference from a netstandard1.3 project to a netstandard1.6 project

Expected
Nuget warning NU1201 in the error list, and a diagnostic message on the P2P reference in the dependencies node, with a warning icon that bubbles up.

Actual
NuGet warning NU1201 does appear, but the P2P node in the dependencies tree has no diagnostic or warning icon

Fixes are needed in:

  • NuGet: generated diagnostic does not have a LibraryId or Target Graph (filed NU1201 Does Not Produce a Library Id NuGet/Home#5405)
  • SDK: diagnostic on projects are not added to dependency node graph
  • Project System: The P2P node in dependencies tree is currently only capable of showing information from the referenced project, but the NuGet diagnostic comes from the referring project. Previously, Project System tried to bypass NuGet/SDK and determine incompatibilities directly, but this leads to .NET Frameworks being treated as incompatible. This is fixed in Fix spurious warnings in dependency node #2435
@natidea natidea added the Bug label Jun 13, 2017
@natidea natidea added this to the 15.6 milestone Jun 13, 2017
@natidea natidea self-assigned this Jun 13, 2017
This was referenced Jun 13, 2017
Merged
Closed
This was referenced Jul 25, 2017
Closed
Closed
@Pilchie Pilchie modified the milestones: 15.5, 15.6 Oct 17, 2017
@Pilchie Pilchie added Area-New-Project-System Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references labels Dec 20, 2017
@Pilchie
Copy link
Member

Pilchie commented Jan 24, 2018

Is #2257 caused by this?

@Pilchie Pilchie modified the milestones: 15.6, 15.7 Feb 11, 2018
@Pilchie Pilchie assigned etbyrd and unassigned natidea Mar 30, 2018
@Pilchie Pilchie modified the milestones: 15.7, 15.8 Mar 30, 2018
@Pilchie Pilchie modified the milestones: 15.8, 16.0 Jul 3, 2018
@jjmew jjmew modified the milestones: 16.0, 16.X Feb 13, 2019
@etbyrd etbyrd removed their assignment Nov 11, 2019
@drewnoakes drewnoakes self-assigned this Mar 21, 2020
@drewnoakes drewnoakes modified the milestones: 16.6, 16.7 Mar 21, 2020
@drewnoakes drewnoakes added the Triage-Approved Reviewed and prioritized label Mar 31, 2020
This was referenced Apr 30, 2020
Merged
Merged
@drewnoakes drewnoakes removed the Bug label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drewnoakes drewnoakes

Labels
Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references Triage-Approved Reviewed and prioritized
Projects
None yet
Milestone
16.7
Development

Successfully merging a pull request may close this issue.

Populate Dependency tree transitive items via the assets file dotnet/project-system
6 participants
@Pilchie @drewnoakes @davkean @natidea @jjmew @etbyrd