Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tool tip for information about dependencies node warnings #4357

Closed
taori opened this issue Dec 9, 2018 · 7 comments
Closed

Use tool tip for information about dependencies node warnings #4357

taori opened this issue Dec 9, 2018 · 7 comments
Assignees
Labels
Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references Parity-Legacy-Feature Missing features from the legacy project system. Triage-Approved Reviewed and prioritized
Milestone

Comments

@taori
Copy link

taori commented Dec 9, 2018

In the past i remember the project tree would display a warning at dependencies and tell me what exactly is wrong with references, by hovering a node. However the tooltips which used to appear, to not appear any longer so i can't really see what's wrong with my project.

grafik

You can check out the repo which points to this: https://github.com/taori/Amusoft.VisualStudio.Extensions/blob/master/templateSources/WpfApplication/Company.Desktop.Application.sln

In order to reproduce the issue.

You will need to enable support for netcore sdk to run the .application.csproj, when attempting to reproduce it with VS 2017.9.2

This is the really confusing one. It tells me i have an issue but won't show me what it is.
grafik

@davkean davkean added this to the 16.0 milestone Dec 9, 2018
@davkean davkean added the Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references label Dec 9, 2018
@davkean
Copy link
Member

davkean commented Dec 9, 2018

tag @drewnoakes

@drewnoakes
Copy link
Member

@taori thanks for the report.

As I understand it, this is a difference between the old project system and this newer one. It's something that's on our radar and we are currently tracking in #2653. I agree that a tool tip seems like a good solution here. We will also consider including something in the error list.

What version of VS are you using?

@drewnoakes drewnoakes added the Parity-Legacy-Feature Missing features from the legacy project system. label Dec 9, 2018
@drewnoakes drewnoakes changed the title Is the project tree bugged regarding displaying dependency issues? Use tool tip for information about dependencies node warnings Dec 9, 2018
@davkean
Copy link
Member

davkean commented Dec 9, 2018

@drewnoakes We are supposed to show errors/warnings from the assets file here in the tree and Error List. I'd check the assets file to see if the issue exists in there and we're not raising it.

@taori
Copy link
Author

taori commented Dec 10, 2018

@drewnoakes

You will need to enable support for netcore sdk to run the .application.csproj, when attempting to reproduce it with VS 2017.9.2

I think i somewhere read that this is a temporary situation of netcore 3.0alpha being integrated in VS2017. However the idea to display those errors anyway should be a thing, which always works, since there appears to be some information available pointing out potential flaws. At least many issues i've encountered while upgrading my projects were at least pointed out as warnings in the error list, unlike this issue. Guess whatever the problem is, is unordinary.

489770dca0fc6d31ffb4d393dc2bf637cb3344a3 is the commit necessary to reproduce i think. In the meantime i've changed some project settings to make my project work and thus removed netstandard crosscompile entirely from WPF related projects.

@abpiskunov
Copy link
Contributor

Images above don't look right: if top level nodes have warning icons they should be propagated to all lower level nodes that have issues. If they are not it is a sign of some timing issue where nodes are out of sync with current state of the dependencies snapshot.

@jjmew jjmew added the Triage-Approved Reviewed and prioritized label Jan 10, 2019
@drewnoakes drewnoakes modified the milestones: 16.0, 16.1 Jan 15, 2019
@drewnoakes drewnoakes added Triage-Approved Reviewed and prioritized and removed Triage-Approved Reviewed and prioritized labels Jan 15, 2019
@drewnoakes drewnoakes modified the milestones: 16.1, 16.2 Apr 3, 2019
@drewnoakes drewnoakes modified the milestones: 16.2, 16.3 Jun 13, 2019
@drewnoakes
Copy link
Member

We are supposed to show errors/warnings from the assets file here in the tree and Error List. I'd check the assets file to see if the issue exists in there and we're not raising it.

This is #3780.

@drewnoakes
Copy link
Member

Closing this as we have other issues tracking the outstanding issues covered here. We're actively working on fixes now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references Parity-Legacy-Feature Missing features from the legacy project system. Triage-Approved Reviewed and prioritized
Projects
None yet
Development

No branches or pull requests

5 participants