Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Produce telemetry on yellow triangles in the dependency tree #6575

Closed
drewnoakes opened this issue Sep 3, 2020 · 1 comment · Fixed by #6593
Closed

Produce telemetry on yellow triangles in the dependency tree #6575

drewnoakes opened this issue Sep 3, 2020 · 1 comment · Fixed by #6593
Assignees
@drewnoakes
Labels
Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references Resolution-Fixed The bug has been fixed, refer to the milestone to see in which release it was fixed. Triage-Approved Reviewed and prioritized
Milestone
16.8

Comments

@drewnoakes
Copy link
Member

We would like to obtain data about the prevalence of warning icons in the dependencies tree in order to monitor progress in their reduction over time.

It's not currently possible to know when a yellow triangle is displayed due to the dependency being incorrectly specified and therefore unresolvable vs. there being a product bug that results in this error state, being that the tree is the last line of defence.

However we do believe that as we reduce the number of product bugs, we should see a reduction in yellow triangles in telemetry.

A pragmatic approach here may be to report the number of resolve/unresolved dependencies of each type when the project is unloaded.
@drewnoakes drewnoakes added the Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references label Sep 3, 2020
@drewnoakes drewnoakes added this to the 16.8 milestone Sep 3, 2020
@drewnoakes drewnoakes self-assigned this Sep 3, 2020
@davkean
Copy link
Member

davkean commented Sep 3, 2020

We already send telemetry when all the trees are finished, that would be a good place to do it.

@jjmew jjmew added the Triage-Approved Reviewed and prioritized label Sep 3, 2020
@drewnoakes drewnoakes mentioned this issue Sep 8, 2020
Merged
@ghost ghost added the Resolution-Fixed The bug has been fixed, refer to the milestone to see in which release it was fixed. label Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drewnoakes drewnoakes

Labels
Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references Resolution-Fixed The bug has been fixed, refer to the milestone to see in which release it was fixed. Triage-Approved Reviewed and prioritized
Projects
None yet
Milestone
16.8
Development

Successfully merging a pull request may close this issue.

Produce telemetry on yellow triangles in the dependency tree drewnoakes/project-system
3 participants
@drewnoakes @davkean @jjmew