Unresolved packages/projects should show errors in dependency tree

[drewnoakes]

The following project references a NuGet package that doesn't exist:

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net7.0</TargetFramework>
    <ImplicitUsings>enable</ImplicitUsings>
    <Nullable>enable</Nullable>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="NonExistantPackage" Version="1.2.3" />
  </ItemGroup>

</Project>

project.assets.json has the following entry:

  "logs": [
    {
      "code": "NU1101",
      "level": "Error",
      "message": "Unable to find package NonExistantPackage. No packages exist with this id in source(s): C:\\Program Files\\dotnet\\library-packs, Microsoft Visual Studio Offline Packages, NuGet local, nuget.org",
      "libraryId": "NonExistantPackage",
      "targetGraphs": [
        "net7.0"
      ]
    }
  ]

This message should be displayed in the tree, yet isn't.

The package node should have a child node containing the error message. Otherwise it is difficult for the user to know why the restore failed, or what the yellow triangle means.

[drewnoakes]

The Package pane of the Output window shows:

Failed to restore C:\repo\MyProject\MyProject.csproj (in 1.1 sec).
NuGet package restore failed. Please see Error List window for detailed warnings and errors.
Time Elapsed: 00:00:01.1176420
========== Finished ==========

The Error List shows:

[drewnoakes]

This problem also occurs for unresolved project references.

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net7.0</TargetFramework>
    <ImplicitUsings>enable</ImplicitUsings>
    <Nullable>enable</Nullable>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="NonExistantPackage" Version="1.2.3" />
    <ProjectReference Include="..\NonExistantProject\NonExistantProject.csproj" />
  </ItemGroup>

</Project>

In project.assets.json:

"logs": [
  {
    "code": "NU1101",
    "level": "Error",
    "message": "Unable to find package NonExistantPackage. No packages exist with this id in source(s): C:\\Program Files\\dotnet\\library-packs, Microsoft Visual Studio Offline Packages, NuGet local, nuget.org",
    "libraryId": "NonExistantPackage",
    "targetGraphs": [
      "net7.0"
    ]
  },
  {
    "code": "NU1104",
    "level": "Error",
    "message": "Unable to find project 'D:\\repos\\issues\\Issue8947UnresolvedPackageWarningMissing\\NonExistantProject\\NonExistantProject.csproj'. Check that the project reference is valid and that the project file exists.",
    "libraryId": "D:\\repos\\issues\\Issue8947UnresolvedPackageWarningMissing\\NonExistantProject\\NonExistantProject.csproj",
    "targetGraphs": [
      "net7.0"
    ]
  }
]

In the UI:

[drewnoakes]

Turns out the fix for this was in our code in the NuGet.Client repo. Fixed in NuGet/NuGet.Client#5146.