Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit state overlay not appearing on package dependency nodes #9368

Closed
drewnoakes opened this issue Jan 9, 2024 · 0 comments · Fixed by #9370
Closed

Implicit state overlay not appearing on package dependency nodes #9368

drewnoakes opened this issue Jan 9, 2024 · 0 comments · Fixed by #9370
Assignees
Labels
Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references Regression Regressions from a previous (typically public) build or release. Resolution-Fixed The bug has been fixed, refer to the milestone to see in which release it was fixed.

Comments

@drewnoakes
Copy link
Member

Before the dependencies tree rewrite in #9008, PackageReference MSBuild items defined outside of the current project's .csproj file would be displayed with a padlock overlay, indicating it's an implicit reference, which may not be removed from the project. Those overlays are no longer visible.

To repro this, create a project and add one package reference to it, and add a Directory.Build.props file with a different package reference in it.

image

In this example, Figgle is added in Directory.Build.props and should show as implicit.

We can see this state works for framework and analyzer nodes:

image


Beyond the lack of visual indicator, we use the implicit state to prevent attempts at deletion by hiding the "Remove" context menu command. In the above screenshot if you attempt to remove the "Figgle" package, you see this error:

image

@drewnoakes drewnoakes added Bug Regression Regressions from a previous (typically public) build or release. Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references labels Jan 9, 2024
@drewnoakes drewnoakes self-assigned this Jan 9, 2024
@ghost ghost added the Resolution-Fixed The bug has been fixed, refer to the milestone to see in which release it was fixed. label Jan 11, 2024
@drewnoakes drewnoakes removed the Bug label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references Regression Regressions from a previous (typically public) build or release. Resolution-Fixed The bug has been fixed, refer to the milestone to see in which release it was fixed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant