Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "UserControl1" item have the same icon with Form1.vb node in the Solution Explore Window for VS 2022 #9600

Open
Zheng-Li01 opened this issue Nov 26, 2024 · 1 comment
Open

The "UserControl1" item have the same icon with Form1.vb node in the Solution Explore Window for VS 2022 #9600

Zheng-Li01 opened this issue Nov 26, 2024 · 1 comment
Assignees
@LittleLittleCloud
Labels
PR-External

Comments

@Zheng-Li01
Copy link
Member

Visual Studio Version

17.13.0 Preview 2.0 [35525.173.main]

Summary

The "UserControl1" have the same icon with Form1.vb node in the Solution Explore Window for VS 20222

Steps to Reproduce

  1. Create a .NET winforms VB project
  2. Add a new User Control(Windows Forms) item for the project
  3. Observer the icon of the userControl1 in the solution explore window

Expected Behavior

The "UserControl1" have the same icon with Form1.vb node in the Solution Explore Window for VS 20222
Image

Actual Behavior

The "UserControl1" have the same icon with Form1.vb node in the Solution Explore Window for VS 20222
Image
Image

User Impact

The "UserControl1" have the same icon with Form1.vb node in the Solution Explore Window for VS 20222

More info:

  1. The issue also can reproduce .NET Framework WinForms VB project
  2. The issue cannot reproduce with C# WinForms project
  3. The issue cannot reproduce on VS 2019
@Zheng-Li01 Zheng-Li01 changed the title The "UserControl1" item have the same icon with Form1.vb node in the Solution Explore Window for VS 20222 The "UserControl1" item have the same icon with Form1.vb node in the Solution Explore Window for VS 2022 Nov 29, 2024
@haileymck haileymck added the Triage-Investigate Reviewed and investigation needed by dev team label Dec 5, 2024
@LittleLittleCloud LittleLittleCloud added PR-External and removed Triage-Investigate Reviewed and investigation needed by dev team labels Dec 19, 2024
@LittleLittleCloud
Copy link
Contributor

The SubType in VS/src/vsproject/Templates/Windows/VisualBasic/ItemTemplates/WindowsForms/UserControl/UserControl.vstemplate is mistakenly set to Form, which causes the UserControl node to have the same icon with Form node.

The fix PR is available in VS repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LittleLittleCloud LittleLittleCloud

Labels
PR-External
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@LittleLittleCloud @Zheng-Li01 @haileymck