TagHelperCollection Part 2: Mechanical Updates (#12505)

| [Prelude](#12503) | [Part
1](#12504) | Part 2 | [Part
3](#12506) | [Part
4](#12507) | [Part
5](#12509) |

> [!WARNING]
> This pull request contains breaking changes for the RazorSdk. Once
this is merged and flows to the VMR,
dotnet/dotnet@9a7e708
will need to be cherry-picked to resolve build breaks in
`src/sdk/src/RazorSdk`.

These commits represent the (mostly) mechanical changes needed to
integrate `TagHelperCollection` across the Razor code base. Most
references to `ImmutableArrary<TagHelperDescriptor>`,
`IReadOnlyList<TagHelperDescriptor>`,
`IEnumerable<TagHelperDescriptor>`, and `TagHelperDescriptor[]` have
been replaced with `TagHelperCollection`. This is **by far** the largest
of the `TagHelperCollection` pull requests.

While most of the commits contain mechanical changes across the code
base, there are few that include more substantial work that require a
bit more scrutiny:

- **Update `RenameService` to remove
`ImmutableArray<TagHelperDescriptor>`**
(fa3ad2b)
This includes a fair amount of refactoring in `RenameService` to fix
bugs found when moving to `TagHelperCollection`.

- **Update `TagHelperFacts` to use `TagHelperCollection`**
Extra work was done in `DirectiveAttributeComplationItemProvider` to
clean up a bit following #12473.

----
CI Build:
https://dev.azure.com/dnceng/internal/_build/results?buildId=2842165&view=results
Toolset Run:
https://dev.azure.com/dnceng/internal/_build/results?buildId=2842237&view=results

Author: DustinCampbell

src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X/test/IntegrationTests/InstrumentationPassIntegrationTest.cs

@@ -31,36 +31,36 @@ public InstrumentationPassIntegrationTest()
     public void BasicTest()
     {
         // Arrange
-        var descriptors = new[]
-        {
-                CreateTagHelperDescriptor(
-                    tagName: "p",
-                    typeName: "PTagHelper",
-                    assemblyName: "TestAssembly"),
-                CreateTagHelperDescriptor(
-                    tagName: "form",
-                    typeName: "FormTagHelper",
-                    assemblyName: "TestAssembly"),
-                CreateTagHelperDescriptor(
-                    tagName: "input",
-                    typeName: "InputTagHelper",
-                    assemblyName: "TestAssembly",
-                    attributes: new Action<BoundAttributeDescriptorBuilder>[]
-                    {
-                        builder => builder
-                            .Name("value")
-                            .PropertyName("FooProp")
-                            .TypeName("System.String"),      // Gets preallocated
-                        builder => builder
-                            .Name("date")
-                            .PropertyName("BarProp")
-                            .TypeName("System.DateTime"),    // Doesn't get preallocated
-                    })
-            };
+        TagHelperCollection tagHelpers =
+        [
+            CreateTagHelperDescriptor(
+                tagName: "p",
+                typeName: "PTagHelper",
+                assemblyName: "TestAssembly"),
+            CreateTagHelperDescriptor(
+                tagName: "form",
+                typeName: "FormTagHelper",
+                assemblyName: "TestAssembly"),
+            CreateTagHelperDescriptor(
+                tagName: "input",
+                typeName: "InputTagHelper",
+                assemblyName: "TestAssembly",
+                attributes:
+                [
+                    builder => builder
+                        .Name("value")
+                        .PropertyName("FooProp")
+                        .TypeName("System.String"),      // Gets preallocated
+                    builder => builder
+                        .Name("date")
+                        .PropertyName("BarProp")
+                        .TypeName("System.DateTime"),    // Doesn't get preallocated
+                ])
+        ];
 
         var engine = CreateProjectEngine(b =>
         {
-            b.AddTagHelpers(descriptors);
+            b.SetTagHelpers(tagHelpers);
             b.Features.Add(new InstrumentationPass());
 
                 // This test includes templates