Skip to content

Commit 2ceb597

Browse files
author
N. Taylor Mullen
committed
Update tests to specify public [Parameter]
- Updated existing tests to use `public` accessibility for parameters. As part of this also updated baselines. - We now recommend that `[Parameter]`'s should be `public`. In the future this will be a requirement. dotnet/aspnetcore#8825
1 parent 32c50db commit 2ceb597

27 files changed

+231
-230
lines changed

src/Razor/test/Microsoft.CodeAnalysis.Razor.Test/BindTagHelperDescriptorProviderTest.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,13 @@ public Task SetParametersAsync(ParameterCollection parameters)
3232
}
3333
3434
[Parameter]
35-
string MyProperty { get; set; }
35+
public string MyProperty { get; set; }
3636
3737
[Parameter]
38-
Action<string> MyPropertyChanged { get; set; }
38+
public Action<string> MyPropertyChanged { get; set; }
3939
4040
[Parameter]
41-
Expression<Func<string>> MyPropertyExpression { get; set; }
41+
public Expression<Func<string>> MyPropertyExpression { get; set; }
4242
}
4343
}
4444
"));
@@ -156,10 +156,10 @@ public Task SetParametersAsync(ParameterCollection parameters)
156156
}
157157
158158
[Parameter]
159-
string MyProperty { get; set; }
159+
public string MyProperty { get; set; }
160160
161161
[Parameter]
162-
EventCallback<string> MyPropertyChanged { get; set; }
162+
public EventCallback<string> MyPropertyChanged { get; set; }
163163
}
164164
}
165165
"));

src/Razor/test/Microsoft.CodeAnalysis.Razor.Test/ComponentTagHelperDescriptorProviderTest.cs

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public Task SetParametersAsync(ParameterCollection parameters)
3131
}
3232
3333
[Parameter]
34-
private string MyProperty { get; set; }
34+
public string MyProperty { get; set; }
3535
}
3636
}
3737
@@ -151,7 +151,7 @@ public Task SetParametersAsync(ParameterCollection parameters)
151151
}
152152
153153
[Parameter]
154-
private string MyProperty { get; set; }
154+
public string MyProperty { get; set; }
155155
}
156156
}
157157
@@ -215,7 +215,7 @@ namespace Test
215215
public class MyComponent : ComponentBase
216216
{
217217
[Parameter]
218-
string MyProperty { get; set; }
218+
public string MyProperty { get; set; }
219219
}
220220
}
221221
@@ -257,7 +257,7 @@ namespace Test
257257
public class MyComponent : ComponentBase
258258
{
259259
[Parameter]
260-
bool MyProperty { get; set; }
260+
public bool MyProperty { get; set; }
261261
}
262262
}
263263
@@ -310,7 +310,7 @@ public enum MyEnum
310310
public class MyComponent : ComponentBase
311311
{
312312
[Parameter]
313-
MyEnum MyProperty { get; set; }
313+
public MyEnum MyProperty { get; set; }
314314
}
315315
}
316316
@@ -357,7 +357,7 @@ namespace Test
357357
public class MyComponent<T> : ComponentBase
358358
{
359359
[Parameter]
360-
T MyProperty { get; set; }
360+
public T MyProperty { get; set; }
361361
}
362362
}
363363
@@ -415,13 +415,13 @@ namespace Test
415415
public class MyComponent<T, U, V> : ComponentBase
416416
{
417417
[Parameter]
418-
T MyProperty1 { get; set; }
418+
public T MyProperty1 { get; set; }
419419
420420
[Parameter]
421-
U MyProperty2 { get; set; }
421+
public U MyProperty2 { get; set; }
422422
423423
[Parameter]
424-
V MyProperty3 { get; set; }
424+
public V MyProperty3 { get; set; }
425425
}
426426
}
427427
@@ -496,7 +496,7 @@ namespace Test
496496
public class MyComponent : ComponentBase
497497
{
498498
[Parameter]
499-
Action<UIMouseEventArgs> OnClick { get; set; }
499+
public Action<UIMouseEventArgs> OnClick { get; set; }
500500
}
501501
}
502502
@@ -546,7 +546,7 @@ namespace Test
546546
public class MyComponent<T> : ComponentBase
547547
{
548548
[Parameter]
549-
Action<T> OnClick { get; set; }
549+
public Action<T> OnClick { get; set; }
550550
}
551551
}
552552
@@ -608,7 +608,7 @@ namespace Test
608608
public class MyComponent : ComponentBase
609609
{
610610
[Parameter]
611-
EventCallback OnClick { get; set; }
611+
public EventCallback OnClick { get; set; }
612612
}
613613
}
614614
@@ -658,7 +658,7 @@ namespace Test
658658
public class MyComponent : ComponentBase
659659
{
660660
[Parameter]
661-
EventCallback<UIMouseEventArgs> OnClick { get; set; }
661+
public EventCallback<UIMouseEventArgs> OnClick { get; set; }
662662
}
663663
}
664664
@@ -713,7 +713,7 @@ namespace Test
713713
public class MyComponent<T> : ComponentBase
714714
{
715715
[Parameter]
716-
EventCallback<T> OnClick { get; set; }
716+
public EventCallback<T> OnClick { get; set; }
717717
}
718718
}
719719
@@ -776,7 +776,7 @@ namespace Test
776776
public class MyComponent : ComponentBase
777777
{
778778
[Parameter]
779-
RenderFragment ChildContent2 { get; set; }
779+
public RenderFragment ChildContent2 { get; set; }
780780
}
781781
}
782782
@@ -833,7 +833,7 @@ namespace Test
833833
public class MyComponent : ComponentBase
834834
{
835835
[Parameter]
836-
RenderFragment<string> ChildContent2 { get; set; }
836+
public RenderFragment<string> ChildContent2 { get; set; }
837837
}
838838
}
839839
@@ -905,10 +905,10 @@ namespace Test
905905
public class MyComponent : ComponentBase
906906
{
907907
[Parameter]
908-
RenderFragment<string> ChildContent2 { get; set; }
908+
public RenderFragment<string> ChildContent2 { get; set; }
909909
910910
[Parameter]
911-
string Context { get; set; }
911+
public string Context { get; set; }
912912
}
913913
}
914914
@@ -980,7 +980,7 @@ namespace Test
980980
public class MyComponent<T> : ComponentBase
981981
{
982982
[Parameter]
983-
RenderFragment<T> ChildContent2 { get; set; }
983+
public RenderFragment<T> ChildContent2 { get; set; }
984984
}
985985
}
986986
@@ -1062,7 +1062,7 @@ namespace Test
10621062
public class MyComponent<T> : ComponentBase
10631063
{
10641064
[Parameter]
1065-
RenderFragment<List<string>> ChildContent2 { get; set; }
1065+
public RenderFragment<List<string>> ChildContent2 { get; set; }
10661066
}
10671067
}
10681068
@@ -1144,7 +1144,7 @@ namespace Test
11441144
public class MyComponent<T> : ComponentBase
11451145
{
11461146
[Parameter]
1147-
RenderFragment<List<T>> ChildContent2 { get; set; }
1147+
public RenderFragment<List<T>> ChildContent2 { get; set; }
11481148
}
11491149
}
11501150
@@ -1225,7 +1225,7 @@ namespace Test
12251225
public class MyComponent<T> : ComponentBase
12261226
{
12271227
[Parameter]
1228-
RenderFragment<Context> ChildContent2 { get; set; }
1228+
public RenderFragment<Context> ChildContent2 { get; set; }
12291229
12301230
public class Context
12311231
{
@@ -1310,13 +1310,13 @@ namespace Test
13101310
public class MyComponent : ComponentBase
13111311
{
13121312
[Parameter]
1313-
RenderFragment ChildContent { get; set; }
1313+
public RenderFragment ChildContent { get; set; }
13141314
13151315
[Parameter]
1316-
RenderFragment<string> Header { get; set; }
1316+
public RenderFragment<string> Header { get; set; }
13171317
13181318
[Parameter]
1319-
RenderFragment<string> Footer { get; set; }
1319+
public RenderFragment<string> Footer { get; set; }
13201320
}
13211321
}
13221322
@@ -1388,21 +1388,21 @@ namespace Test
13881388
public abstract class MyBase : ComponentBase
13891389
{
13901390
[Parameter]
1391-
protected string Hidden { get; set; }
1391+
public string Hidden { get; set; }
13921392
}
13931393
13941394
public class MyComponent : MyBase
13951395
{
13961396
[Parameter]
1397-
string NoSetter { get; }
1397+
public string NoSetter { get; }
13981398
13991399
[Parameter]
1400-
static string StaticProperty { get; set; }
1400+
public static string StaticProperty { get; set; }
14011401
14021402
public string NoParameterAttribute { get; set; }
14031403
14041404
// No attribute here, hides base-class property of the same name.
1405-
protected new int Hidden { get; set; }
1405+
public new int Hidden { get; set; }
14061406
14071407
public string this[int i]
14081408
{

src/Razor/test/RazorLanguage.Test/IntegrationTests/ComponentChildContentIntegrationTest.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ protected override void BuildRenderTree(RenderTreeBuilder builder)
2323
}
2424
2525
[Parameter]
26-
RenderFragment ChildContent { get; set; }
26+
public RenderFragment ChildContent { get; set; }
2727
}
2828
}
2929
");
@@ -41,10 +41,10 @@ protected override void BuildRenderTree(RenderTreeBuilder builder)
4141
}
4242
4343
[Parameter]
44-
RenderFragment<string> ChildContent { get; set; }
44+
public RenderFragment<string> ChildContent { get; set; }
4545
4646
[Parameter]
47-
string Value { get; set; }
47+
public string Value { get; set; }
4848
}
4949
}
5050
");
@@ -64,19 +64,19 @@ protected override void BuildRenderTree(RenderTreeBuilder builder)
6464
}
6565
6666
[Parameter]
67-
string Name { get; set; }
67+
public string Name { get; set; }
6868
6969
[Parameter]
70-
RenderFragment<string> Header { get; set; }
70+
public RenderFragment<string> Header { get; set; }
7171
7272
[Parameter]
73-
RenderFragment<string> ChildContent { get; set; }
73+
public RenderFragment<string> ChildContent { get; set; }
7474
7575
[Parameter]
76-
RenderFragment Footer { get; set; }
76+
public RenderFragment Footer { get; set; }
7777
7878
[Parameter]
79-
string Value { get; set; }
79+
public string Value { get; set; }
8080
}
8181
}
8282
");

0 commit comments

Comments
 (0)