Address code review feedback

- IntermediateNodeFormatter: Move const to the method where it is used.
- ComponentBindLoweringPass: Add missing type pattern to switch expression.
- ComponentMarkupDiagnosticPass: Replace expressions with existing local.

Author: DustinCampbell

src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Components/ComponentBindLoweringPass.cs

@@ -1146,6 +1146,7 @@ IntermediateToken GetToken(IntermediateNode parent)
         var originalSpan = node switch
         {
             ComponentAttributeIntermediateNode n => n.OriginalAttributeSpan,
+            TagHelperDirectiveAttributeIntermediateNode n => n.OriginalAttributeSpan,
             TagHelperDirectiveAttributeParameterIntermediateNode n => n.OriginalAttributeSpan,
             TagHelperPropertyIntermediateNode n => n.OriginalAttributeSpan,
             _ => null

src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Components/ComponentDuplicateAttributeDiagnosticPass.cs

@@ -44,17 +44,17 @@ public override void VisitMarkupElement(MarkupElementIntermediateNode node)
 
                         if (originalAttributeName != null)
                         {
-                            other.node.AddDiagnostic(ComponentDiagnosticFactory.Create_DuplicateMarkupAttributeDirective(
+                            otherAttribute.AddDiagnostic(ComponentDiagnosticFactory.Create_DuplicateMarkupAttributeDirective(
                                 other.name,
                                 originalAttributeName,
-                                other.node.Source ?? node.Source));
+                                otherAttribute.Source ?? node.Source));
                         }
                         else
                         {
                             // This is a conflict in the code the user wrote.
-                            other.node.AddDiagnostic(ComponentDiagnosticFactory.Create_DuplicateMarkupAttribute(
+                            otherAttribute.AddDiagnostic(ComponentDiagnosticFactory.Create_DuplicateMarkupAttribute(
                                 other.name,
-                                other.node.Source ?? node.Source));
+                                otherAttribute.Source ?? node.Source));
                         }
                     }
 

src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Intermediate/IntermediateNodeFormatter.cs

@@ -28,7 +28,6 @@ public enum FormatterMode
         PreferProperties,
     }
 
-    private const string ShortNameSuffix = nameof(IntermediateNode);
     private static readonly Dictionary<Type, string> s_nodeTypeToShortNameMap = [];
 
     private static readonly char[] s_charsToEscape = ['\r', '\n', '\t'];
@@ -49,6 +48,8 @@ private static string GetNodeShortName(IntermediateNode node)
 
         static string ComputeShortName(Type type)
         {
+            const string ShortNameSuffix = nameof(IntermediateNode);
+
             var shortName = type.Name;
 
             if (shortName.EndsWith(ShortNameSuffix, StringComparison.Ordinal))