Use the overload that takes an immutable array in serailization (#11393)

Noticed this while doing the preprocessor symbols, and was reminded of
it in the working group meeting.

These are all immutable arrays, but were calling a serialize method that
took an `IReadOnlyList`, so would have boxed an enumerator and not
handled default.

Author: davidwengier

src/Shared/Microsoft.AspNetCore.Razor.Serialization.Json/JsonDataWriter.cs

@@ -312,14 +312,6 @@ public void WriteArrayIfNotNullOrEmpty<T>(string propertyName, IEnumerable<T>? e
         }
     }
 
-    public void WriteArrayIfNotNullOrEmpty<T>(string propertyName, IReadOnlyList<T>? elements, WriteValue<T> writeElement)
-    {
-        if (elements is { Count: > 0 })
-        {
-            WriteArray(propertyName, elements, writeElement);
-        }
-    }
-
     public void WriteArrayIfNotDefaultOrEmpty<T>(string propertyName, ImmutableArray<T> elements, WriteValue<T> writeElement)
     {
         if (!elements.IsDefaultOrEmpty)

src/Shared/Microsoft.AspNetCore.Razor.Serialization.Json/ObjectWriters.cs

@@ -41,7 +41,7 @@ public static void WriteProperties(JsonDataWriter writer, RazorConfiguration val
         writer.WriteIfNotFalse(nameof(value.UseRoslynTokenizer), value.UseRoslynTokenizer);
         writer.WriteArrayIfNotDefaultOrEmpty(nameof(value.PreprocessorSymbols), value.PreprocessorSymbols, static (w, v) => w.Write(v));
 
-        writer.WriteArrayIfNotNullOrEmpty(nameof(value.Extensions), value.Extensions, static (w, v) => w.Write(v.ExtensionName));
+        writer.WriteArrayIfNotDefaultOrEmpty(nameof(value.Extensions), value.Extensions, static (w, v) => w.Write(v.ExtensionName));
     }
 
     public static void Write(JsonDataWriter writer, RazorDiagnostic? value)

src/Shared/Microsoft.AspNetCore.Razor.Serialization.Json/ObjectWriters_TagHelpers.cs

@@ -24,11 +24,11 @@ public static void WriteProperties(JsonDataWriter writer, TagHelperDescriptor va
         WriteDocumentationObject(writer, nameof(value.Documentation), value.DocumentationObject);
         writer.WriteIfNotNull(nameof(value.TagOutputHint), value.TagOutputHint);
         writer.Write(nameof(value.CaseSensitive), value.CaseSensitive);
-        writer.WriteArrayIfNotNullOrEmpty(nameof(value.TagMatchingRules), value.TagMatchingRules, WriteTagMatchingRule);
-        writer.WriteArrayIfNotNullOrEmpty(nameof(value.BoundAttributes), value.BoundAttributes, WriteBoundAttribute);
-        writer.WriteArrayIfNotNullOrEmpty(nameof(value.AllowedChildTags), value.AllowedChildTags, WriteAllowedChildTag);
+        writer.WriteArrayIfNotDefaultOrEmpty(nameof(value.TagMatchingRules), value.TagMatchingRules, WriteTagMatchingRule);
+        writer.WriteArrayIfNotDefaultOrEmpty(nameof(value.BoundAttributes), value.BoundAttributes, WriteBoundAttribute);
+        writer.WriteArrayIfNotDefaultOrEmpty(nameof(value.AllowedChildTags), value.AllowedChildTags, WriteAllowedChildTag);
         WriteMetadata(writer, nameof(value.Metadata), value.Metadata);
-        writer.WriteArrayIfNotNullOrEmpty(nameof(value.Diagnostics), value.Diagnostics, Write);
+        writer.WriteArrayIfNotDefaultOrEmpty(nameof(value.Diagnostics), value.Diagnostics, Write);
 
         static void WriteDocumentationObject(JsonDataWriter writer, string propertyName, DocumentationObject documentationObject)
         {
@@ -68,8 +68,8 @@ static void WriteTagMatchingRule(JsonDataWriter writer, TagMatchingRuleDescripto
                 writer.WriteIfNotNull(nameof(value.ParentTag), value.ParentTag);
                 writer.WriteIfNotZero(nameof(value.TagStructure), (int)value.TagStructure);
                 writer.WriteIfNotTrue(nameof(value.CaseSensitive), value.CaseSensitive);
-                writer.WriteArrayIfNotNullOrEmpty(nameof(value.Attributes), value.Attributes, WriteRequiredAttribute);
-                writer.WriteArrayIfNotNullOrEmpty(nameof(value.Diagnostics), value.Diagnostics, Write);
+                writer.WriteArrayIfNotDefaultOrEmpty(nameof(value.Attributes), value.Attributes, WriteRequiredAttribute);
+                writer.WriteArrayIfNotDefaultOrEmpty(nameof(value.Diagnostics), value.Diagnostics, Write);
             });
         }
 
@@ -85,7 +85,7 @@ static void WriteRequiredAttribute(JsonDataWriter writer, RequiredAttributeDescr
                 writer.WriteIfNotNull(nameof(value.DisplayName), value.DisplayName);
 
                 WriteMetadata(writer, nameof(value.Metadata), value.Metadata);
-                writer.WriteArrayIfNotNullOrEmpty(nameof(value.Diagnostics), value.Diagnostics, Write);
+                writer.WriteArrayIfNotDefaultOrEmpty(nameof(value.Diagnostics), value.Diagnostics, Write);
             });
         }
 
@@ -105,10 +105,10 @@ static void WriteBoundAttribute(JsonDataWriter writer, BoundAttributeDescriptor
                 WriteDocumentationObject(writer, nameof(value.Documentation), value.DocumentationObject);
                 writer.WriteIfNotTrue(nameof(value.CaseSensitive), value.CaseSensitive);
                 writer.WriteIfNotFalse(nameof(value.IsEditorRequired), value.IsEditorRequired);
-                writer.WriteArrayIfNotNullOrEmpty("BoundAttributeParameters", value.Parameters, WriteBoundAttributeParameter);
+                writer.WriteArrayIfNotDefaultOrEmpty("BoundAttributeParameters", value.Parameters, WriteBoundAttributeParameter);
 
                 WriteMetadata(writer, nameof(value.Metadata), value.Metadata);
-                writer.WriteArrayIfNotNullOrEmpty(nameof(value.Diagnostics), value.Diagnostics, Write);
+                writer.WriteArrayIfNotDefaultOrEmpty(nameof(value.Diagnostics), value.Diagnostics, Write);
             });
         }
 
@@ -125,7 +125,7 @@ static void WriteBoundAttributeParameter(JsonDataWriter writer, BoundAttributePa
                 writer.WriteIfNotTrue(nameof(value.CaseSensitive), value.CaseSensitive);
 
                 WriteMetadata(writer, nameof(value.Metadata), value.Metadata);
-                writer.WriteArrayIfNotNullOrEmpty(nameof(value.Diagnostics), value.Diagnostics, Write);
+                writer.WriteArrayIfNotDefaultOrEmpty(nameof(value.Diagnostics), value.Diagnostics, Write);
             });
         }