Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch razor tooling to use source generator #8081

Closed
chsienki opened this issue Jan 5, 2023 · 1 comment
Closed

Switch razor tooling to use source generator #8081

chsienki opened this issue Jan 5, 2023 · 1 comment
Labels
area-compiler Umbrella for all compiler issues tooling big rock ⚪
Milestone

Comments

@chsienki
Copy link
Contributor

chsienki commented Jan 5, 2023

Today, the razor tooling hosts its own copy of the compiler APIs, which it uses to generate documents, which are then injected into the Roslyn workspace. The razor source generator is explicitly disabled to allow this.

This has the unfortunate side-effect that when performing an initial hot reload edit, the generator must start from scratch, which is slow.

If we change the tooling to instead 'pull' documents from the Roslyn workspace that are created by the source generator, we can have the 'warmed up' for the first hot reload. This should also remove some complexity from the tooling (and Roslyn) as it will no longer be responsible for injecting the files into the Roslyn workspace.

@ghost ghost added the untriaged label Jan 5, 2023
@chsienki chsienki removed the untriaged label Jan 5, 2023
@ghost ghost added the untriaged label Jan 5, 2023
@chsienki chsienki added tooling big rock ⚪ area-compiler Umbrella for all compiler issues and removed untriaged labels Jan 5, 2023
@ghost ghost added the untriaged label Jan 5, 2023
@chsienki chsienki added this to the 17.6 P1 milestone Jan 5, 2023
@ghost ghost removed the untriaged label Jan 5, 2023
@chsienki
Copy link
Contributor Author

chsienki commented Jan 5, 2023

Dupe of #6919

@chsienki chsienki closed this as completed Jan 5, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-compiler Umbrella for all compiler issues tooling big rock ⚪
Projects
None yet
Development

No branches or pull requests

1 participant