Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and Un-skip Rename Integration tests #8121

Open
ryanbrandenburg opened this issue Jan 11, 2023 · 2 comments
Open

Improve and Un-skip Rename Integration tests #8121

ryanbrandenburg opened this issue Jan 11, 2023 · 2 comments
Assignees

Comments

@ryanbrandenburg
Copy link
Contributor

They currently fail with a couple of problems. Some of those issues are on the WebTools/Platform end (https://devdiv.visualstudio.com/DevDiv/_git/WebTools/pullrequest/444996, https://devdiv.visualstudio.com/DevDiv/_git/WebTools/pullrequest/444453 and https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1715306/) once those are resolved and merged we should re-visit.

@DoctorKrolic
Copy link
Contributor

@davidwengier Are the underlying problems resolved here? I keep revisiting this issue from time to time since I still want to add integration tests for renaming component's type parameter as I mentioned in #8909 (serious dedication, isn't it). I remember you did Tuesday endpoint cleanup days, maybe it's a good idea to have "Tuesday cleanup and reenable integration tests day" this week then)

@davidwengier
Copy link
Member

I don't honestly know. You are welcome to put up a PR with a new test, or with the existing tests unskipped, and see whether the CI is green. There have been lots of changes since they were disabled, but I can't say whether they will have worked around any issues, and I'm on my phone so can't check the internal MS links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants