Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request options from the client when the server starts #9240

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Request options from the client when the server starts #9240

merged 1 commit into from
Sep 6, 2023

Conversation

davidwengier
Copy link
Contributor

Fixes #9224 by honouring the razor.format.enable setting

@davidwengier davidwengier requested a review from a team as a code owner September 5, 2023 06:32
@davidwengier davidwengier mentioned this pull request Sep 5, 2023
Closed
ryzngard
ryzngard approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@ryzngard ryzngard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, is there any way to test this? Even if we just assert that RazorConfigurationEndpoint is registered as IOnInitialized somehow. I've also been wondering if we can start using DI in unit testing, but that's a completely separate thing

@davidwengier davidwengier merged commit d54dc86 into dotnet:main Sep 6, 2023
@davidwengier davidwengier deleted the VSCodeOptions branch September 6, 2023 01:07
@ghost ghost added this to the Next milestone Sep 6, 2023
@davidwengier
Copy link
Contributor Author

Whoops, missed your comment Andrew, sorry.

The only way to test would be by using mocks and verify that when the OnInitializedAsync method is called, it calls to make an LSP request, but that doesn't seem like much value to me. Obviously I manually tested in VS Code :)

davidwengier added a commit to davidwengier/vscode-csharp that referenced this pull request Sep 6, 2023
@davidwengier
Bump Razor to fix dotnet/razor#9240
9ddc7ad
@allisonchou allisonchou mentioned this pull request Sep 6, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.8 P3 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzngard ryzngard ryzngard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.8
Development

Successfully merging this pull request may close these issues.

The option "razor.disabled" is gone.
3 participants
@davidwengier @ryzngard @Cosifne