Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ProjectSnapshotManagerAccessor #9514

Closed
DustinCampbell opened this issue Nov 1, 2023 · 1 comment · Fixed by #10063
Closed

Remove ProjectSnapshotManagerAccessor #9514

DustinCampbell opened this issue Nov 1, 2023 · 1 comment · Fixed by #10063
Assignees
@DustinCampbell
Labels
tech-debt
Milestone
17.10 P3

Comments

@DustinCampbell
Copy link
Member

The ProjectSnapshotManager service is defined as a Roslyn language service and can be acquired from a Roslyn workspace. However, it is also exposed as a MEF export via the ProjectSnapshotManagerAccessor class. This issue tracks removing the accessor class and the Roslyn language service, and expoorting the ProjectSnapshotManager singleton via MEF.
@ghost ghost added the untriaged label Nov 1, 2023
@DustinCampbell DustinCampbell self-assigned this Nov 1, 2023
@phil-allen-msft phil-allen-msft added this to the 17.9 P1 milestone Nov 2, 2023
@ghost ghost removed the untriaged label Nov 2, 2023
@phil-allen-msft phil-allen-msft modified the milestones: 17.9 P1, 17.10 P1 Jan 5, 2024
@phil-allen-msft phil-allen-msft modified the milestones: 17.10 P1, 17.10 P2 Feb 13, 2024
@phil-allen-msft phil-allen-msft modified the milestones: 17.10 P2, 17.10 P3 Mar 11, 2024
@DustinCampbell
Copy link
Member Author

Fixed by #10063

@DustinCampbell DustinCampbell mentioned this issue Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DustinCampbell DustinCampbell

Labels
tech-debt
Projects
None yet
Milestone
17.10 P3
2 participants
@DustinCampbell @phil-allen-msft