Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post co-hosting cleanup #9814

Open
1 of 6 tasks
davidwengier opened this issue Jan 12, 2024 · 2 comments
Open
1 of 6 tasks

Post co-hosting cleanup #9814

davidwengier opened this issue Jan 12, 2024 · 2 comments
Assignees
Milestone

Comments

@davidwengier
Copy link
Member

davidwengier commented Jan 12, 2024

This issue is a grab bag tracking things that were changed to enable us to work on cohosting, but we don't expect to be part of the final delivered solution.

  • Remove DocumentVersionCache
    • Roslyn TextDocument is inherently versioned
  • Remove DocumentState
    • Roslyn tracks document state in TextDocument, and the source generator does too via its pipeline.
  • Remove ProjectState
    • Roslyn tracks project state in Project, and the source generator does the rest in its pipeline.
  • Reduce the properties on DocumentSnapshot and ProjectSnapshot
    • If DocumentSnapshot remains in existence it should be a very light wrapper over a Roslyn document, and a convenient way to access data from the source generator. It should not store state, generally speaking.
  • Maybe remove DocumentSnapshot/ProjectSnapshot
    • If the above removes enough properties, maybe DocumentContext is enough
  • Alternative to the above, perhaps RemoteDocumentSnapshot is the type we use most often, and it allows access to the TextDocument for a Razor document, and the SourceGeneratedDocument for a generated document, and mapping between the two.
@DustinCampbell
Copy link
Member

Are any of the above needed for HTML?

@davidwengier
Copy link
Member Author

Most of my day yesterday was spent staring at the wall trying to answer that question :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants