Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IProjectSnapshotManager.Changed handlers are unordered #9817

Open
DustinCampbell opened this issue Jan 12, 2024 · 5 comments
Open

IProjectSnapshotManager.Changed handlers are unordered #9817

DustinCampbell opened this issue Jan 12, 2024 · 5 comments

Comments

@DustinCampbell
Copy link
Member

Many services dependent on ProjectSnapshotManager are imported as IProjectSnapshotChangeTrigger and that is the order in which they'll receive change notifications from the manager. There isn't a good way to represent ordering, so services update in a non-deterministic way. For example, DocumentVersionCache might not update before another service needs an accurate value from it.

@davidwengier
Copy link
Member

There is a mechanism for "high priority" triggers, which will receive a notification before all non-high-priority. Still not ordered within each set however.

@DustinCampbell
Copy link
Member Author

I know that's there, but there's just one service using it. FWIW, I don't know that there are any issues relating to ordering today, but I can't be certain. This is probably just a really hard reliability bug waiting to happen. 😄 I'd like to deal with it as part of #9806.

@phil-allen-msft phil-allen-msft added this to the 17.10 Planning milestone Jan 24, 2024
@ghost ghost removed the untriaged label Jan 24, 2024
@DustinCampbell DustinCampbell changed the title IProjectSnapshotChangeTrigger dependencies are unordered IProjectSnapshotManager.Changed handlers are unordered Apr 23, 2024
@ryzngard
Copy link
Contributor

ryzngard commented May 1, 2024

@DustinCampbell I'm going to assign to you for now to help the health of our unassigned yet triaged bug list. Let me know if that's incorrect, and feel free to update the milestone as needed

@DustinCampbell
Copy link
Member Author

This isn't a critical issue. Just something I noticed. This should be backlog tech debt.

@davidwengier
Copy link
Member

@DustinCampbell given IProjectSnapshotChangeTrigger is no more, can this be closed? There still isn't ordering of notifications of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants