Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator testing should assert cancellation token respect in a timely manner #1098

Open
Youssef1313 opened this issue Jun 4, 2023 · 1 comment
Labels
Area-MS.CA.Testing Microsoft.CodeAnalysis.Testing

Comments

@Youssef1313
Copy link
Member

Per dotnet/runtime#68353, not respecting cancellation token has performance impact. The testing should assert that cancelling will happen in a timely manner.

@sharwell
Copy link
Member

sharwell commented Jun 5, 2023

There is no straightforward way to test this on CI virtual machines with a wide variety of performance characteristics. In general, it seems analyzers are a better way to handle this.

@sharwell sharwell added the Area-MS.CA.Testing Microsoft.CodeAnalysis.Testing label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-MS.CA.Testing Microsoft.CodeAnalysis.Testing
Projects
None yet
Development

No branches or pull requests

2 participants