Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default template NuGet.config #742

Closed
Youssef1313 opened this issue Mar 2, 2021 · 3 comments
Closed

Default template NuGet.config #742

Youssef1313 opened this issue Mar 2, 2021 · 3 comments

Comments

@Youssef1313
Copy link
Member

It was updated in #725 to prevent dependency confusion attack.

While the template would build just find, it's unclear what analyzer authors should do for dogfooding.

Analyzers authors obviously don't own dotnet-tools or dotnet-public feeds.

It's also now discouraged to mix public and private feeds.

cc: @mmitche

@sharwell
Copy link
Member

sharwell commented Mar 2, 2021

The template was erroneously updated. I'll work to get it reverted.

@Youssef1313
Copy link
Member Author

While there is no problem at all if nuget.org is used with the default template, I think that makes it easier for consumers to make a mistake that makes their project vulnerable.

@Youssef1313
Copy link
Member Author

I'm going to close since it the package was uploaded to NuGet.org. Thanks @jmarolf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants