Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ease restriction on inserting earlier builds #806

Open
RikkiGibson opened this issue Aug 11, 2020 · 2 comments
Open

Ease restriction on inserting earlier builds #806

RikkiGibson opened this issue Aug 11, 2020 · 2 comments

Comments

@RikkiGibson
Copy link
Contributor

The insertion tool currently fails if you try to insert an "older" build than what is currently present in the base branch.

https://dev.azure.com/devdiv/DevDiv/_releaseProgress?_a=release-environment-logs&releaseId=776275&environmentId=4206948

However, an "older" build may actually represent newer source, such as when you manually queue a build for some earlier commit, then insert it, then go back and try to insert an earlier build that represents a later commit. @JoeRobich @genlu what do you think about removing this restriction?

@genlu
Copy link
Member

genlu commented Aug 11, 2020

I think there's a check in VS build that ensures the version number doesn't decrease? Anyway, I think this is fine if the tool can make a comment in the insertion PR saying so, which needs to be manually resolved by someone before merge.

@JoeRobich
Copy link
Member

I feel like there could be a flag to override this behavior. Since, most of the time not allowing build numbers to go backwards is the right thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants