Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub PR comment when PR Validation is complete #886

Open
JoeRobich opened this issue Jan 29, 2021 · 2 comments
Open

Add GitHub PR comment when PR Validation is complete #886

JoeRobich opened this issue Jan 29, 2021 · 2 comments

Comments

@JoeRobich
Copy link
Member

When a Roslyn Validation PR is created, we should comment a link to the VS PR on the Roslyn PR being validated. This would be performed by new logic in the OneOffInsertion script that is used to generate the insertion PRs.

@davidwengier
Copy link
Contributor

I wonder if it would be useful, especially for community contributors who can't see the insertions, to also have the comment include the feed URL and version information for the packages that are published to the general-testing nuget feed?

@JoeRobich
Copy link
Member Author

Possible verbiage:

A validation build has been started for this PR. Click here to view (Microsoft only)

Package Information:
Version Feed
3.10.0-1.21078.40 https://pkgs.dev.azure.com/dnceng/public/_packaging/general-testing/nuget/v3/index.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants