Merge pull request #44463 from mavasani/EnforceCA1822

[Dogfooding] Enforce "Make member static" for IDE projects

Author: mavasani

.editorconfig

@@ -261,3 +261,6 @@ dotnet_diagnostic.IDE0059.severity = warning
 
 # IDE0060: Remove unused parameter
 dotnet_diagnostic.IDE0060.severity = warning
+
+# CA1822: Make member static
+dotnet_diagnostic.CA1822.severity = warning

src/Analyzers/CSharp/Analyzers/AddAccessibilityModifiers/CSharpAddAccessibilityModifiersDiagnosticAnalyzer.cs

@@ -20,7 +20,7 @@ public CSharpAddAccessibilityModifiersDiagnosticAnalyzer()
         {
         }
 
-        private CSharpSyntaxFacts SyntaxFacts => CSharpSyntaxFacts.Instance;
+        private static CSharpSyntaxFacts SyntaxFacts => CSharpSyntaxFacts.Instance;
 
         protected override void ProcessCompilationUnit(
             SyntaxTreeAnalysisContext context,

src/Analyzers/CSharp/Analyzers/InlineDeclaration/CSharpInlineDeclarationDiagnosticAnalyzer.cs

@@ -237,7 +237,7 @@ private void AnalyzeSyntaxNode(SyntaxNodeAnalysisContext context, INamedTypeSymb
                 properties: null));
         }
 
-        private bool WouldCauseDefiniteAssignmentErrors(
+        private static bool WouldCauseDefiniteAssignmentErrors(
             SemanticModel semanticModel,
             LocalDeclarationStatementSyntax localStatement,
             BlockSyntax enclosingBlock,
@@ -260,7 +260,7 @@ private bool WouldCauseDefiniteAssignmentErrors(
             return dataFlow.DataFlowsIn.Contains(outLocalSymbol);
         }
 
-        private SyntaxNode GetOutArgumentScope(SyntaxNode argumentExpression)
+        private static SyntaxNode GetOutArgumentScope(SyntaxNode argumentExpression)
         {
             for (var current = argumentExpression; current != null; current = current.Parent)
             {
@@ -312,7 +312,7 @@ private SyntaxNode GetOutArgumentScope(SyntaxNode argumentExpression)
             return null;
         }
 
-        private bool IsAccessed(
+        private static bool IsAccessed(
             SemanticModel semanticModel,
             ISymbol outSymbol,
             BlockSyntax enclosingBlockOfLocalStatement,

src/Analyzers/CSharp/Analyzers/InvokeDelegateWithConditionalAccess/InvokeDelegateWithConditionalAccessAnalyzer.cs

@@ -305,7 +305,7 @@ private bool TryCheckVariableAndIfStatementForm(
             return true;
         }
 
-        private bool IsNullCheckExpression(ExpressionSyntax left, ExpressionSyntax right) =>
+        private static bool IsNullCheckExpression(ExpressionSyntax left, ExpressionSyntax right) =>
             left.IsKind(SyntaxKind.IdentifierName) && right.IsKind(SyntaxKind.NullLiteralExpression);
 
         public override DiagnosticAnalyzerCategory GetAnalyzerCategory()

src/Analyzers/CSharp/Analyzers/QualifyMemberAccess/CSharpQualifyMemberAccessDiagnosticAnalyzer.cs

@@ -42,18 +42,18 @@ protected override bool CanMemberAccessBeQualified(ISymbol containingSymbol, Syn
                      IsInPropertyOrFieldInitialization(containingSymbol, node));
         }
 
-        private bool IsInPropertyOrFieldInitialization(ISymbol containingSymbol, SyntaxNode node)
+        private static bool IsInPropertyOrFieldInitialization(ISymbol containingSymbol, SyntaxNode node)
         {
             return (containingSymbol.Kind == SymbolKind.Field || containingSymbol.Kind == SymbolKind.Property) &&
                 containingSymbol.DeclaringSyntaxReferences
                     .Select(declaringSyntaxReferences => declaringSyntaxReferences.GetSyntax())
                     .Any(declaringSyntax => IsInPropertyInitialization(declaringSyntax, node) || IsInFieldInitialization(declaringSyntax, node));
         }
 
-        private bool IsInPropertyInitialization(SyntaxNode declarationSyntax, SyntaxNode node)
+        private static bool IsInPropertyInitialization(SyntaxNode declarationSyntax, SyntaxNode node)
             => declarationSyntax.IsKind(SyntaxKind.PropertyDeclaration) && declarationSyntax.Contains(node);
 
-        private bool IsInFieldInitialization(SyntaxNode declarationSyntax, SyntaxNode node)
+        private static bool IsInFieldInitialization(SyntaxNode declarationSyntax, SyntaxNode node)
             => declarationSyntax.GetAncestorsOrThis(n => n.IsKind(SyntaxKind.FieldDeclaration) && n.Contains(node)).Any();
 
         protected override Location GetLocation(IOperation operation) => operation.Syntax.GetLocation();

src/Analyzers/CSharp/Analyzers/UseAutoProperty/CSharpUseAutoPropertyAnalyzer.cs

@@ -118,7 +118,7 @@ void AddIneligibleField(ISymbol symbol)
             }
         }
 
-        private bool CheckExpressionSyntactically(ExpressionSyntax expression)
+        private static bool CheckExpressionSyntactically(ExpressionSyntax expression)
         {
             if (expression.IsKind(SyntaxKind.SimpleMemberAccessExpression, out MemberAccessExpressionSyntax memberAccessExpression))
             {
@@ -152,7 +152,7 @@ protected override ExpressionSyntax GetGetterExpression(IMethodSymbol getMethod,
             return CheckExpressionSyntactically(expr) ? expr : null;
         }
 
-        private ExpressionSyntax GetGetterExpressionFromSymbol(IMethodSymbol getMethod, CancellationToken cancellationToken)
+        private static ExpressionSyntax GetGetterExpressionFromSymbol(IMethodSymbol getMethod, CancellationToken cancellationToken)
         {
             var declaration = getMethod.DeclaringSyntaxReferences[0].GetSyntax(cancellationToken);
             switch (declaration)
@@ -167,7 +167,7 @@ private ExpressionSyntax GetGetterExpressionFromSymbol(IMethodSymbol getMethod,
             }
         }
 
-        private T GetSingleStatementFromAccessor<T>(AccessorDeclarationSyntax accessorDeclaration) where T : StatementSyntax
+        private static T GetSingleStatementFromAccessor<T>(AccessorDeclarationSyntax accessorDeclaration) where T : StatementSyntax
         {
             var statements = accessorDeclaration?.Body?.Statements;
             if (statements?.Count == 1)
@@ -203,7 +203,7 @@ protected override ExpressionSyntax GetSetterExpression(
             return null;
         }
 
-        private ExpressionSyntax GetExpressionFromSetter(AccessorDeclarationSyntax setAccessor)
+        private static ExpressionSyntax GetExpressionFromSetter(AccessorDeclarationSyntax setAccessor)
             => setAccessor?.ExpressionBody?.Expression ??
                GetSingleStatementFromAccessor<ExpressionStatementSyntax>(setAccessor)?.Expression;
 

src/Analyzers/CSharp/Analyzers/UseExpressionBody/UseExpressionBodyDiagnosticAnalyzer.cs

@@ -88,7 +88,7 @@ private void AnalyzeSyntax(SyntaxNodeAnalysisContext context)
             }
         }
 
-        private Diagnostic AnalyzeSyntax(
+        private static Diagnostic AnalyzeSyntax(
             OptionSet optionSet, SyntaxNode declaration, UseExpressionBodyHelper helper)
         {
             var preferExpressionBodiedOption = optionSet.GetOption(helper.Option);

src/Analyzers/CSharp/Analyzers/UseImplicitOrExplicitType/CSharpTypeStyleDiagnosticAnalyzerBase.cs

@@ -75,7 +75,7 @@ private void HandleVariableDeclaration(SyntaxNodeAnalysisContext context)
             context.ReportDiagnostic(CreateDiagnostic(descriptor, declarationStatement, declaredType.StripRefIfNeeded().Span, typeStyle.Severity));
         }
 
-        private Diagnostic CreateDiagnostic(DiagnosticDescriptor descriptor, SyntaxNode declaration, TextSpan diagnosticSpan, ReportDiagnostic severity)
+        private static Diagnostic CreateDiagnostic(DiagnosticDescriptor descriptor, SyntaxNode declaration, TextSpan diagnosticSpan, ReportDiagnostic severity)
             => DiagnosticHelper.Create(descriptor, declaration.SyntaxTree.GetLocation(diagnosticSpan), severity, additionalLocations: null, properties: null);
     }
 }

src/Analyzers/CSharp/Analyzers/UseIndexOrRangeOperator/CSharpUseIndexOperatorDiagnosticAnalyzer.cs

@@ -220,7 +220,7 @@ private void AnalyzeInvokedMember(
                     ImmutableDictionary<string, string>.Empty));
         }
 
-        private IPropertySymbol TryGetLengthLikeProperty(InfoCache infoCache, IMethodSymbol targetMethodOpt)
+        private static IPropertySymbol TryGetLengthLikeProperty(InfoCache infoCache, IMethodSymbol targetMethodOpt)
             => targetMethodOpt != null && infoCache.TryGetMemberInfo(targetMethodOpt, out var memberInfo)
                 ? memberInfo.LengthLikeProperty
                 : null;

src/Analyzers/CSharp/Analyzers/UseIndexOrRangeOperator/CSharpUseRangeOperatorDiagnosticAnalyzer.InfoCache.cs

@@ -51,7 +51,7 @@ public InfoCache(Compilation compilation)
                 }
             }
 
-            private IMethodSymbol GetSliceLikeMethod(INamedTypeSymbol namedType)
+            private static IMethodSymbol GetSliceLikeMethod(INamedTypeSymbol namedType)
                 => namedType.GetMembers()
                             .OfType<IMethodSymbol>()
                             .Where(m => IsSliceLikeMethod(m))