Merge pull request #6790 from sharwell/inline-array

Avoid reporting CA1823 for inline arrays

Author: sharwell

src/Test.Utilities/AdditionalMetadataReferences.cs

@@ -1,6 +1,7 @@
 // Copyright (c) Microsoft.  All Rights Reserved.  Licensed under the MIT license.  See License.txt in the project root for license information.
 
 using System.Collections.Immutable;
+using System.IO;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.Testing;
@@ -9,6 +10,13 @@ namespace Test.Utilities
 {
     public static class AdditionalMetadataReferences
     {
+        public static ReferenceAssemblies Net80 { get; } = new ReferenceAssemblies(
+            "net8.0",
+            new PackageIdentity(
+                "Microsoft.NETCore.App.Ref",
+                "8.0.0-preview.6.23329.7"),
+            Path.Combine("ref", "net8.0"));
+
         public static ReferenceAssemblies Default { get; } = CreateDefaultReferenceAssemblies();
 
         public static ReferenceAssemblies DefaultWithoutRoslynSymbols { get; } = ReferenceAssemblies.Default

src/Utilities/Compiler/Extensions/ISymbolExtensions.cs

@@ -626,7 +626,7 @@ public static bool IsReadOnlyFieldOrProperty([NotNullWhen(returnValue: true)] th
             return symbol.GetAttributes(attributeType).FirstOrDefault();
         }
 
-        public static IEnumerable<AttributeData> GetAttributes(this ISymbol symbol, IEnumerable<INamedTypeSymbol> attributesToMatch)
+        public static IEnumerable<AttributeData> GetAttributes(this ISymbol symbol, IEnumerable<INamedTypeSymbol?> attributesToMatch)
         {
             foreach (var attribute in symbol.GetAttributes())
             {
@@ -659,6 +659,20 @@ public static bool HasAnyAttribute(this ISymbol symbol, params INamedTypeSymbol?
             return symbol.GetAttributes(attributeTypesToMatch).Any();
         }
 
+        public static bool HasAnyAttribute(this ISymbol symbol, [NotNullWhen(true)] INamedTypeSymbol? attributeToMatch)
+        {
+            if (attributeToMatch is null)
+                return false;
+
+            foreach (var attribute in symbol.GetAttributes())
+            {
+                if (SymbolEqualityComparer.Default.Equals(attribute.AttributeClass, attributeToMatch))
+                    return true;
+            }
+
+            return false;
+        }
+
         /// <summary>
         /// Returns a value indicating whether the specified symbol has the specified
         /// attribute.

src/Utilities/Compiler/WellKnownTypeNames.cs

@@ -306,6 +306,7 @@ internal static class WellKnownTypeNames
         public const string SystemRuntimeCompilerServicesConfiguredValueTaskAwaitable1 = "System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable`1";
         public const string SystemRuntimeCompilerServicesDisableRuntimeMarshallingAttribute = "System.Runtime.CompilerServices.DisableRuntimeMarshallingAttribute";
         public const string SystemRuntimeCompilerServicesICriticalNotifyCompletion = "System.Runtime.CompilerServices.ICriticalNotifyCompletion";
+        public const string SystemRuntimeCompilerServicesInlineArrayAttribute = "System.Runtime.CompilerServices.InlineArrayAttribute";
         public const string SystemRuntimeCompilerServicesINotifyCompletion = "System.Runtime.CompilerServices.INotifyCompletion";
         public const string SystemRuntimeCompilerServicesInternalsVisibleToAttribute = "System.Runtime.CompilerServices.InternalsVisibleToAttribute";
         public const string SystemRuntimeCompilerServicesMethodImplOptions = "System.Runtime.CompilerServices.MethodImplOptions";