Localize exception messages for gladstone/roslyn integration (#78063)

Author: CyrusNajmabadi

src/Features/Core/Portable/Extensions/ExtensionFolder.cs

@@ -118,7 +118,7 @@ public void RegisterAssembly(string assemblyFilePath)
                 // If this throws, it also indicated a bug in gladstone that must be fixed.  As such, it is ok if this
                 // tears down the extension service in OOP.
                 if (_assemblyFilePathToHandlers.ContainsKey(assemblyFilePath))
-                    throw new InvalidOperationException($"Extension '{assemblyFilePath}' is already registered.");
+                    throw new InvalidOperationException(string.Format(FeaturesResources.Extension_0_is_already_registered, assemblyFilePath));
 
                 _assemblyFilePathToHandlers = _assemblyFilePathToHandlers.Add(
                    assemblyFilePath,
@@ -141,7 +141,7 @@ public void RegisterAssembly(string assemblyFilePath)
                 // If this throws, it also indicated a bug in gladstone that must be fixed.  As such, it is ok if this
                 // tears down the extension service in OOP.
                 if (!_assemblyFilePathToHandlers.TryGetValue(assemblyFilePath, out var lazyHandlers))
-                    throw new InvalidOperationException($"Extension '{assemblyFilePath}' was not registered.");
+                    throw new InvalidOperationException(string.Format(FeaturesResources.Extension_0_was_not_registered, assemblyFilePath));
 
                 _assemblyFilePathToHandlers = _assemblyFilePathToHandlers.Remove(assemblyFilePath);
                 return (_assemblyFilePathToHandlers.Count == 0, lazyHandlers);
@@ -156,7 +156,7 @@ public async ValueTask<ExtensionMessageNames> GetExtensionMessageNamesAsync(stri
                 // If this throws, it also indicated a bug in gladstone that must be fixed.  As such, it is ok if this
                 // tears down the extension service in OOP.
                 if (!_assemblyFilePathToHandlers.TryGetValue(assemblyFilePath, out var lazyHandlers))
-                    throw new InvalidOperationException($"Extension '{assemblyFilePath}' was not registered.");
+                    throw new InvalidOperationException(string.Format(FeaturesResources.Extension_0_was_not_registered, assemblyFilePath));
 
                 // Handlers already encapsulates any extension-level exceptions that occurred when loading the assembly.
                 // As such, we don't need our own try/catch here.  We can just return the result directly.

src/Features/Core/Portable/Extensions/ExtensionMessageHandlerService.cs

@@ -60,7 +60,7 @@ private sealed partial class ExtensionMessageHandlerService(
         private static string GetAssemblyFolderPath(string assemblyFilePath)
         {
             return Path.GetDirectoryName(assemblyFilePath)
-                ?? throw new InvalidOperationException($"Unable to get the directory name for {assemblyFilePath}.");
+                ?? throw new InvalidOperationException(string.Format(FeaturesResources.Unable_to_get_the_directory_name_for_0, assemblyFilePath));
         }
 
         private void ClearCachedHandlers_WhileUnderLock()
@@ -114,7 +114,7 @@ private ValueTask UnregisterExtensionInCurrentProcessAsync(string assemblyFilePa
                 lock (_gate)
                 {
                     if (!_folderPathToExtensionFolder.TryGetValue(assemblyFolderPath, out var extensionFolder))
-                        throw new InvalidOperationException($"No extension registered as '{assemblyFolderPath}'");
+                        throw new InvalidOperationException(string.Format(FeaturesResources.No_extension_registered_as_0, assemblyFolderPath));
 
                     // Clear out the cached handler names.  They will be recomputed the next time we need them.
                     ClearCachedHandlers_WhileUnderLock();
@@ -174,7 +174,7 @@ private async ValueTask<ExtensionMessageNames> GetExtensionMessageNamesInCurrent
             // Throwing here indicates a bug in the gladstone client itself.  So we want this to bubble outwards as a
             // failure that disables extension running in the OOP process.  This must be fixed by gladstone.
             if (!_folderPathToExtensionFolder.TryGetValue(assemblyFolderPath, out var extensionFolder))
-                throw new InvalidOperationException($"No extensions registered at '{assemblyFolderPath}'");
+                throw new InvalidOperationException(string.Format(FeaturesResources.No_extensions_registered_at_0, assemblyFolderPath));
 
             // Note if loading the extension assembly failed (due to issues in the extension itself), then the exception
             // produced by it will be passed outwards as data in the ExtensionMessageNames result.
@@ -219,14 +219,14 @@ private async ValueTask<ExtensionMessageResult> HandleExtensionMessageInCurrentP
                 // bug in the gladstone client itself (as it allowed calling into an lsp message that never had
                 // registered handlers).  So we want this to bubble outwards as a failure that disables extension
                 // running in the OOP process.  This must be fixed by gladstone.
-                throw new InvalidOperationException($"No handler found for message {messageName}.");
+                throw new InvalidOperationException(string.Format(FeaturesResources.No_handler_found_for_message_0, messageName));
             }
 
             // Throwing here indicates a bug in the gladstone client itself (as it allowed calling into an lsp message
             // that had multiple registered handlers).  So we want this to bubble outwards as a failure that disables
             // extension running in the OOP process.  This must be fixed by gladstone.
             if (handlers.Length > 1)
-                throw new InvalidOperationException($"Multiple handlers found for message {messageName}.");
+                throw new InvalidOperationException(string.Format(FeaturesResources.Multiple_handlers_found_for_message_0, messageName));
 
             var handler = (IExtensionMessageHandlerWrapper<TArgument>)handlers[0];
 

src/Features/Core/Portable/FeaturesResources.resx

@@ -3205,4 +3205,25 @@ Zero-width positive lookbehind assertions are typically used at the beginning of
     <value>Convert to 'field' property</value>
     <comment>{Locked="field"} "field" is C# keyword and should not be localized.</comment>
   </data>
+  <data name="Extension_0_is_already_registered" xml:space="preserve">
+    <value>Extension '{0}' is already registered.</value>
+  </data>
+  <data name="Extension_0_was_not_registered" xml:space="preserve">
+    <value>Extension '{0}' was not registered.</value>
+  </data>
+  <data name="Unable_to_get_the_directory_name_for_0" xml:space="preserve">
+    <value>Unable to get the directory name for {0}.</value>
+  </data>
+  <data name="No_extension_registered_as_0" xml:space="preserve">
+    <value>No extension registered as '{0}'.</value>
+  </data>
+  <data name="No_extensions_registered_at_0" xml:space="preserve">
+    <value>No extensions registered at '{0}'.</value>
+  </data>
+  <data name="No_handler_found_for_message_0" xml:space="preserve">
+    <value>No handler found for message {0}.</value>
+  </data>
+  <data name="Multiple_handlers_found_for_message_0" xml:space="preserve">
+    <value>Multiple handlers found for message {0}.</value>
+  </data>
 </root>