Bump versions of System.Collections.Immutable and System.Reflection.Metadata to consume the new function pointer metadata changes.

Author: 333fred

eng/Versions.props

@@ -252,8 +252,8 @@
     -->
     <NewtonsoftJsonVersion>12.0.2</NewtonsoftJsonVersion>
     <StreamJsonRpcVersion>2.4.34</StreamJsonRpcVersion>
-    <SystemCollectionsImmutableVersion>1.5.0</SystemCollectionsImmutableVersion>
-    <SystemReflectionMetadataVersion>1.6.0</SystemReflectionMetadataVersion>
+    <SystemCollectionsImmutableVersion>5.0.0-preview.8.20371.14</SystemCollectionsImmutableVersion>
+    <SystemReflectionMetadataVersion>5.0.0-preview.8.20371.14</SystemReflectionMetadataVersion>
     <MicrosoftVisualStudioStaticReviewsEmbeddableVersion>0.1.102-alpha</MicrosoftVisualStudioStaticReviewsEmbeddableVersion>
     <MicrosoftBclAsyncInterfacesVersion>1.1.0</MicrosoftBclAsyncInterfacesVersion>
   </PropertyGroup>

src/Analyzers/Core/Analyzers/RemoveUnnecessarySuppressions/AbstractRemoveUnnecessaryPragmaSuppressionsDiagnosticAnalyzer.cs

@@ -60,7 +60,7 @@ private ImmutableHashSet<int> GetSupportedCompilerErrorCodes()
                 var methodInfo = compilerAnalyzerType.GetMethod("GetSupportedErrorCodes", BindingFlags.Instance | BindingFlags.NonPublic)!;
                 var compilerAnalyzerInstance = Activator.CreateInstance(compilerAnalyzerType);
                 var supportedCodes = methodInfo.Invoke(compilerAnalyzerInstance, Array.Empty<object>()) as IEnumerable<int>;
-                return supportedCodes.ToImmutableHashSet();
+                return supportedCodes?.ToImmutableHashSet() ?? ImmutableHashSet<int>.Empty;
             }
             catch (Exception ex)
             {

src/Compilers/CSharp/Portable/Binder/DecisionDagBuilder.cs

@@ -1005,7 +1005,7 @@ private static (
                 }
                 IValueSet fromTestPassing = valueFac.Related(relation.Operator(), value);
                 IValueSet fromTestFailing = fromTestPassing.Complement();
-                if (values.TryGetValue(test.Input, out IValueSet tempValuesBeforeTest))
+                if (values.TryGetValue(test.Input, out IValueSet? tempValuesBeforeTest))
                 {
                     fromTestPassing = fromTestPassing.Intersect(tempValuesBeforeTest);
                     fromTestFailing = fromTestFailing.Intersect(tempValuesBeforeTest);

src/Compilers/CSharp/Portable/Compilation/CSharpCompilation.cs

@@ -3664,7 +3664,7 @@ void WriteValue(string key, string value)
 
         private ImmutableArray<string> GetPreprocessorSymbols()
         {
-            CSharpSyntaxTree firstTree = (CSharpSyntaxTree)SyntaxTrees.FirstOrDefault();
+            CSharpSyntaxTree? firstTree = (CSharpSyntaxTree?)SyntaxTrees.FirstOrDefault();
 
             if (firstTree is null)
             {

src/Compilers/CSharp/Portable/Compilation/MemberSemanticModel.cs

@@ -704,7 +704,7 @@ private T GetRemappedSymbol<T>(T originalSymbol) where T : Symbol
             EnsureNullabilityAnalysisPerformedIfNecessary();
             if (_lazyRemappedSymbols is null) return originalSymbol;
 
-            if (_lazyRemappedSymbols.TryGetValue(originalSymbol, out Symbol remappedSymbol))
+            if (_lazyRemappedSymbols.TryGetValue(originalSymbol, out Symbol? remappedSymbol))
             {
                 RoslynDebug.Assert(remappedSymbol is object);
                 return (T)remappedSymbol;

src/Compilers/CSharp/Portable/FlowAnalysis/NullableWalker.SnapshotManager.cs

@@ -6,6 +6,7 @@
 using System.Collections.Generic;
 using System.Collections.Immutable;
 using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp.Symbols;
 using Microsoft.CodeAnalysis.PooledObjects;
 using Roslyn.Utilities;
@@ -98,7 +99,7 @@ private SnapshotManager(ImmutableArray<SharedWalkerState> walkerSharedStates, Im
                 return null;
             }
 
-            internal bool TryGetUpdatedSymbol(BoundNode node, Symbol symbol, out Symbol updatedSymbol)
+            internal bool TryGetUpdatedSymbol(BoundNode node, Symbol symbol, [NotNullWhen(true)] out Symbol? updatedSymbol)
             {
                 return _updatedSymbolsMap.TryGetValue((node, symbol), out updatedSymbol);
             }

src/Compilers/CSharp/Portable/Symbols/Source/SourceMemberContainerSymbol.cs

@@ -1514,7 +1514,7 @@ private void CheckMemberNameConflicts(DiagnosticBag diagnostics)
             foreach (var pair in membersByName)
             {
                 var name = pair.Key;
-                Symbol lastSym = GetTypeMembers(name).FirstOrDefault();
+                Symbol? lastSym = GetTypeMembers(name).FirstOrDefault();
                 methodsBySignature.Clear();
                 // Conversion collisions do not consider the name of the conversion,
                 // so do not clear that dictionary.
@@ -1561,7 +1561,7 @@ private void CheckMemberNameConflicts(DiagnosticBag diagnostics)
                     //   following a field of the same name, or a field and a nested type of the same name.
                     //
 
-                    if ((object)lastSym != null)
+                    if ((object?)lastSym != null)
                     {
                         if (symbol.Kind != SymbolKind.Method || lastSym.Kind != SymbolKind.Method)
                         {

src/Compilers/Core/Portable/Collections/StaticCast.cs

@@ -12,7 +12,10 @@ internal static class StaticCast<T>
     {
         internal static ImmutableArray<T> From<TDerived>(ImmutableArray<TDerived> from) where TDerived : class?, T
         {
+            // Remove the pragma when we get a version with https://github.com/dotnet/runtime/issues/39799 fixed
+#pragma warning disable CS8634
             return ImmutableArray<T>.CastUp(from);
+#pragma warning restore CS8634
         }
     }
 }

src/Compilers/Core/Portable/CommandLine/AnalyzerConfig.cs

@@ -83,7 +83,7 @@ public sealed partial class AnalyzerConfig
         /// <summary>
         /// Gets whether this editorconfig is a topmost editorconfig.
         /// </summary>
-        internal bool IsRoot => GlobalSection.Properties.TryGetValue("root", out string val) && val == "true";
+        internal bool IsRoot => GlobalSection.Properties.TryGetValue("root", out string? val) && val == "true";
 
         /// <summary>
         /// Gets whether this editorconfig is a global editorconfig.

src/Compilers/Core/Portable/DiagnosticAnalyzer/AnalysisResult.cs

@@ -114,6 +114,7 @@ private static void AddLocalDiagnostics<T>(
             ImmutableDictionary<T, ImmutableDictionary<DiagnosticAnalyzer, ImmutableArray<Diagnostic>>> localDiagnostics,
             ImmutableHashSet<DiagnosticAnalyzer> excludedAnalyzers,
             ImmutableArray<Diagnostic>.Builder builder)
+            where T : notnull
         {
             foreach (var diagnosticsByTree in localDiagnostics)
             {